Skip to content

Bump PackageValidationBaselineVersion for 13.2#16008

Merged
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:UpdatePackageValidation
Apr 9, 2026
Merged

Bump PackageValidationBaselineVersion for 13.2#16008
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:UpdatePackageValidation

Conversation

@eerhardt
Copy link
Copy Markdown
Member

@eerhardt eerhardt commented Apr 9, 2026

Also enable package validation on libraries that are now shipped stable.

Also enable package validation on libraries that are now shipped stable.
@eerhardt eerhardt requested a review from joperezr April 9, 2026 18:51
@eerhardt eerhardt requested a review from JamesNK as a code owner April 9, 2026 18:51
Copilot AI review requested due to automatic review settings April 9, 2026 18:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16008

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16008"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Aspire’s package validation baseline to the latest 13.2 patch release and turns on baseline validation for additional libraries that have now shipped as stable packages.

Changes:

  • Bumped PackageValidationBaselineVersion from 13.1.2 to 13.2.2.
  • Enabled baseline package validation for newly-stable libraries by removing DisablePackageBaselineValidation.
  • Added/updated CompatibilitySuppressions.xml files to record known baseline compatibility suppressions.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Directory.Build.props Updates the global package validation baseline version to 13.2.2.
src/Aspire.TypeSystem/CompatibilitySuppressions.xml Adds baseline suppressions needed when enabling package validation for Aspire.TypeSystem.
src/Aspire.TypeSystem/Aspire.TypeSystem.csproj Enables baseline validation by removing DisablePackageBaselineValidation.
src/Aspire.Hosting/CompatibilitySuppressions.xml Refreshes baseline suppressions for Aspire.Hosting against the new baseline.
src/Aspire.Hosting.Docker/CompatibilitySuppressions.xml Adds baseline suppressions needed when enabling package validation for Aspire.Hosting.Docker.
src/Aspire.Hosting.Docker/Aspire.Hosting.Docker.csproj Enables baseline validation by removing DisablePackageBaselineValidation.
src/Aspire.Hosting.DevTunnels/Aspire.Hosting.DevTunnels.csproj Enables baseline validation by removing DisablePackageBaselineValidation.
src/Aspire.Hosting.Azure.Network/Aspire.Hosting.Azure.Network.csproj Enables baseline validation by removing DisablePackageBaselineValidation.

<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Aspire.Hosting.Docker.Resources.ServiceNodes.Swarm.UpdateConfig.get_FailOnError</Target>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Suppression>
<DiagnosticId>CP0021</DiagnosticId>
<Target>M:Aspire.Hosting.ResourceBuilderExtensions.WithRemoteImageTag``1(Aspire.Hosting.ApplicationModel.IResourceBuilder{``0},System.String)``0:T:Aspire.Hosting.ApplicationModel.IComputeResource</Target>
<Target>M:Aspire.Hosting.ResourceBuilderExtensions.WithRelationship``1(Aspire.Hosting.ApplicationModel.IResourceBuilder{``0},Aspire.Hosting.ApplicationModel.IResourceBuilder{Aspire.Hosting.ApplicationModel.IResource},System.String)</Target>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fixed with Merge release13.2 into main (microsoft/aspire#16007)

This API was introduced (#15557) in the release/13.2 branch but hasn't been migrated to main yet.

<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Aspire.TypeSystem.RuntimeSpec.get_MigrationFiles</Target>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above - will be fixed with Merge release13.2 into main (microsoft/aspire#16007)

@eerhardt eerhardt enabled auto-merge (squash) April 9, 2026 19:06
@eerhardt eerhardt merged commit 159a804 into microsoft:main Apr 9, 2026
270 checks passed
@eerhardt eerhardt deleted the UpdatePackageValidation branch April 9, 2026 20:13
eerhardt added a commit to eerhardt/aspire that referenced this pull request Apr 10, 2026
The NameOutput property was renamed to NameOutputReference in microsoft#16004,
and the baseline version was bumped in microsoft#16008. Add CP0002 suppressions
for the removed NameOutput getters on the 5 affected network resources.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eerhardt added a commit that referenced this pull request Apr 10, 2026
…#16022)

The NameOutput property was renamed to NameOutputReference in #16004,
and the baseline version was bumped in #16008. Add CP0002 suppressions
for the removed NameOutput getters on the 5 affected network resources.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants