Bump PackageValidationBaselineVersion for 13.2#16008
Conversation
Also enable package validation on libraries that are now shipped stable.
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16008Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16008" |
There was a problem hiding this comment.
Pull request overview
Updates Aspire’s package validation baseline to the latest 13.2 patch release and turns on baseline validation for additional libraries that have now shipped as stable packages.
Changes:
- Bumped
PackageValidationBaselineVersionfrom13.1.2to13.2.2. - Enabled baseline package validation for newly-stable libraries by removing
DisablePackageBaselineValidation. - Added/updated
CompatibilitySuppressions.xmlfiles to record known baseline compatibility suppressions.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Directory.Build.props | Updates the global package validation baseline version to 13.2.2. |
| src/Aspire.TypeSystem/CompatibilitySuppressions.xml | Adds baseline suppressions needed when enabling package validation for Aspire.TypeSystem. |
| src/Aspire.TypeSystem/Aspire.TypeSystem.csproj | Enables baseline validation by removing DisablePackageBaselineValidation. |
| src/Aspire.Hosting/CompatibilitySuppressions.xml | Refreshes baseline suppressions for Aspire.Hosting against the new baseline. |
| src/Aspire.Hosting.Docker/CompatibilitySuppressions.xml | Adds baseline suppressions needed when enabling package validation for Aspire.Hosting.Docker. |
| src/Aspire.Hosting.Docker/Aspire.Hosting.Docker.csproj | Enables baseline validation by removing DisablePackageBaselineValidation. |
| src/Aspire.Hosting.DevTunnels/Aspire.Hosting.DevTunnels.csproj | Enables baseline validation by removing DisablePackageBaselineValidation. |
| src/Aspire.Hosting.Azure.Network/Aspire.Hosting.Azure.Network.csproj | Enables baseline validation by removing DisablePackageBaselineValidation. |
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:Aspire.Hosting.Docker.Resources.ServiceNodes.Swarm.UpdateConfig.get_FailOnError</Target> |
There was a problem hiding this comment.
| <Suppression> | ||
| <DiagnosticId>CP0021</DiagnosticId> | ||
| <Target>M:Aspire.Hosting.ResourceBuilderExtensions.WithRemoteImageTag``1(Aspire.Hosting.ApplicationModel.IResourceBuilder{``0},System.String)``0:T:Aspire.Hosting.ApplicationModel.IComputeResource</Target> | ||
| <Target>M:Aspire.Hosting.ResourceBuilderExtensions.WithRelationship``1(Aspire.Hosting.ApplicationModel.IResourceBuilder{``0},Aspire.Hosting.ApplicationModel.IResourceBuilder{Aspire.Hosting.ApplicationModel.IResource},System.String)</Target> |
There was a problem hiding this comment.
This will be fixed with Merge release13.2 into main (microsoft/aspire#16007)
This API was introduced (#15557) in the release/13.2 branch but hasn't been migrated to main yet.
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:Aspire.TypeSystem.RuntimeSpec.get_MigrationFiles</Target> |
There was a problem hiding this comment.
Same as above - will be fixed with Merge release13.2 into main (microsoft/aspire#16007)
The NameOutput property was renamed to NameOutputReference in microsoft#16004, and the baseline version was bumped in microsoft#16008. Add CP0002 suppressions for the removed NameOutput getters on the 5 affected network resources. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Also enable package validation on libraries that are now shipped stable.