[release/13.2] Backport: Show anonymous dashboard URLs in aspire ps#15749
[release/13.2] Backport: Show anonymous dashboard URLs in aspire ps#15749joperezr merged 1 commit intorelease/13.2from
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15749Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15749" |
There was a problem hiding this comment.
Pull request overview
Backport to release/13.2 fixing aspire ps dashboard URL display when the AppHost dashboard is configured for anonymous access by having the backchannel surface the base dashboard URL even when no browser token is configured.
Changes:
- Update dashboard URL resolution to return the base URL when
DashboardTokenis not configured (anonymous/unsecured mode), while preserving/login?t=...URLs when a token exists. - Add hosting and CLI regression tests covering anonymous dashboard URL propagation into
ps --format json. - Extend the test builder helper with an overload that accepts both
ITestOutputHelperand command-line args.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.Tests/Utils/TestDistributedApplicationBuilder.cs | Adds a helper overload to pass args + output helper for tests that need configuration-driven scenarios. |
| tests/Aspire.Hosting.Tests/Backchannel/AuxiliaryBackchannelRpcTargetTests.cs | Adds a regression test ensuring anonymous dashboard mode returns the base URL via the auxiliary backchannel. |
| tests/Aspire.Cli.Tests/Commands/PsCommandTests.cs | Adds a regression test verifying aspire ps --format json includes an anonymous dashboard URL. |
| src/Aspire.Hosting/Backchannel/DashboardUrlsHelper.cs | Adjusts URL construction to return base URL when no browser token is configured; keeps Codespaces rewriting behavior. |
| src/Aspire.Hosting/Backchannel/BackchannelDataTypes.cs | Updates documentation to reflect that returned URLs may be tokenized or plain depending on auth mode. |
| src/Aspire.Hosting/Backchannel/AuxiliaryBackchannelRpcTarget.cs | Updates documentation to match the new “resolved dashboard URLs” behavior. |
| src/Aspire.Cli/Backchannel/IAppHostAuxiliaryBackchannel.cs | Updates documentation for the dashboard URL state returned from the AppHost. |
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
|
🎬 CLI E2E Test Recordings — 52 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23837405169 |
Description
Backport of #15731 to
release/13.2.aspire psleft the Dashboard column empty when the AppHost was configured with anonymous dashboard access (ASPIRE_DASHBOARD_UNSECURED_ALLOW_ANONYMOUS/DOTNET_DASHBOARD_UNSECURED_ALLOW_ANONYMOUS). This change makes the backchannel surface the dashboard base URL in anonymous mode so CLI output can display it.Cherry-picked from
010f4a76a2with two merge conflicts resolved (MCP-related code inAuxiliaryBackchannelRpcTarget.csandDashboardUrlsHelper.csthat exists onrelease/13.2but not onmain).Validation: All 1770 CLI tests pass, all 9 AuxiliaryBackchannelRpcTargetTests pass.
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: