Fix failed rollouts counted as completed in AgentModeDaemon#480
Open
Mr-Neutr0n wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix failed rollouts counted as completed in AgentModeDaemon#480Mr-Neutr0n wants to merge 1 commit intomicrosoft:mainfrom
Mr-Neutr0n wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When vLLM returns HTTP 400 errors, the resulting rollouts have None reward and empty triplets. Previously these were still counted as completed, which caused the task count to exceed the total queued (e.g. "Completed 33/32 tasks") and triggered assertion failures in get_train_data_batch. This change: - Adds _is_failed_rollout() to detect rollouts with no reward and no triplets, indicating a backend error rather than a real result - Skips failed rollouts instead of storing them, allowing the task to be re-claimed and retried - For v1 mode, only polls for pending (not yet completed) rollout IDs so that successful retries are properly picked up - Removes the early "already processed" skip that could prevent a successful retry from overwriting a stale entry Fixes microsoft#355
Author
|
Friendly bump! Let me know if there's anything I should update or improve to help move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #355
Nonereward and empty triplets. These were previously counted as "completed" in_async_run_until_finished, causing the completed count to exceed_total_tasks_queued(e.g. "Completed 33/32 tasks") and triggering assertion failures inget_train_data_batch._is_failed_rollout()helper that detects rollouts with no reward and no triplets, identifying them as backend failures rather than real results.wait_for_rolloutsnow only polls for rollout IDs that have not yet successfully completed, so successful retries are properly picked up.Test plan
get_train_data_batchno longer hits theassert len(self._completed_rollouts_v0) == self._total_tasks_queuedassertion