.NET: Inline private RunCoreAsync into the protected one#3928
Open
SergeyMenshykh wants to merge 3 commits intomicrosoft:mainfrom
Open
.NET: Inline private RunCoreAsync into the protected one#3928SergeyMenshykh wants to merge 3 commits intomicrosoft:mainfrom
SergeyMenshykh wants to merge 3 commits intomicrosoft:mainfrom
Conversation
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
had a problem deploying
to
integration
GitHub Actions
Error
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the ChatClientAgent.RunCoreAsync method by inlining the logic from a private generic helper method directly into the protected method. The private generic RunCoreAsync<TAgentResponse, TChatClientResponse> method was no longer needed since there was only one concrete usage, making the abstraction unnecessary.
Changes:
- Removed the private generic
RunCoreAsync<TAgentResponse, TChatClientResponse>method - Inlined its logic directly into the protected
RunCoreAsyncmethod - Replaced generic type parameters with concrete types (
ChatResponseandAgentResponse)
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
had a problem deploying
to
integration
GitHub Actions
Failure
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation, Context and Description
The private
RunCoreAsyncmethod is no longer needed, so its content has been inlined into the protected method.