Skip to content

dev#2028

Merged
baywet merged 14 commits intomainfrom
dev
Dec 24, 2024
Merged

dev#2028
baywet merged 14 commits intomainfrom
dev

Conversation

baywet and others added 10 commits December 20, 2024 10:47
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
fix: reverts to a regular variable for the tag value
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.6.1 to 28.7.0.
- [Release notes](https://github.com/VerifyTests/Verify/releases)
- [Commits](VerifyTests/Verify@28.6.1...28.7.0)

---
updated-dependencies:
- dependency-name: Verify.Xunit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…-28.7.0

chore(deps): bump Verify.Xunit from 28.6.1 to 28.7.0
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet self-assigned this Dec 24, 2024
Comment on lines +102 to +105
if (value.GetValueKind() == JsonValueKind.Number)
Value = value.GetValue<decimal>().ToString(CultureInfo.InvariantCulture);
else
Value = value.GetValue<string>();

Check notice

Code scanning / CodeQL

Missed ternary opportunity Note

Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.
baywet and others added 3 commits December 24, 2024 09:18
@sonarqubecloud
Copy link

@baywet baywet merged commit cce2495 into main Dec 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants