fix misleading comments: Mz uses c (not r) in PPSNARK#414
Open
GarmashAlex wants to merge 3 commits intomicrosoft:mainfrom
Open
fix misleading comments: Mz uses c (not r) in PPSNARK#414GarmashAlex wants to merge 3 commits intomicrosoft:mainfrom
GarmashAlex wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes misleading comments in the ppsnark.rs file that incorrectly referenced the variable 'r' when describing the Mz polynomial and its evaluation. The code correctly uses the Fiat-Shamir challenge 'c', but the comments were inconsistent with the implementation.
- Corrected variable references in comments from 'r' to 'c' for Mz polynomial construction
- Updated evaluation comments to match the actual code that uses challenge 'c'
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace r with c in comments describing Mz and its evaluation in ppsnark.rs. The code already uses the Fiat–Shamir challenge c to form Mz = Az + cBz + c^2Cz and its evaluation at tau; only the comments were incorrect.