feat(spartan/polynomial): Update polynomial with docs and new methods#215
Merged
srinathsetty merged 2 commits intomicrosoft:mainfrom Aug 7, 2023
Merged
Conversation
- Add documentation to spartan/polynomial.rs file - Make polynomial crate public to easily generate docs and encourage API use - Add Add trait and scalar_mul method - Add tests for polynomial functions Co-authored-by: wangtsiao <wang.qi.ao@qq.com> Co-authored-by: CPerezz <c.perezbaro@gmail.com>
Otherwise `cargo doc` doesn't run.
srinathsetty
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a smaller PR that is cut out from larger work of implementing HyperNova #175 (latest live version is here https://github.com/privacy-scaling-explorations/nova)
A problem that occurred when we were implementing HyperNova is that we didn't fully understand the embedded spartan/polynomial.rs code, and thus reached for other tools such as can be seen here #175 (comment)
By adding better documentation and tests for this module it is easier to understand what is going on.
This PR: