U/sgriffin/vc2026 by stephenegriffin · Pull Request #167 · microsoft/MAPIStubLibrary

stephenegriffin · 2026-02-06T20:54:40Z

No description provided.

- Create Directory.Build.props for centralized build configuration - Update solution file to VS 18 format - Update .vsconfig to require Windows 11 SDK (10.0.22621.0) - Remove PlatformToolset and WindowsTargetPlatformVersion from mapistub.vcxproj - Remove Guardian .gdn ruleset references (CI-only dependency) Breaking change: Requires Visual Studio 2026

github-actions · 2026-02-06T20:57:43Z

Test Results

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit de2788f. ± Comparison against base commit f8fbf74.

♻️ This comment has been updated with latest results.

Prefast analysis now enabled on-demand via MSBuild property (/p:EnablePREfast=true) instead of separate build configurations.

Copilot

Pull request overview

Updates the Windows/Visual Studio build setup to target a newer toolset/SDK baseline and align CI/security scanning workflows with those build requirements.

Changes:

Centralizes MSBuild defaults (toolset/SDK pin + security/quality flags) via Directory.Build.props and removes per-configuration duplication from the .vcxproj.
Updates the solution/project configurations (drops Prefast configs) and bumps the .sln Visual Studio version metadata.
Updates GitHub Actions workflows (new Windows runner label, ARM64EC matrix, Windows 11 SDK install step) and bumps CodeQL action SHAs.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`mapistub.vcxproj`	Removes per-config toolset/SDK/security flags and drops Prefast/Fuzz ARM64* configurations in favor of repo-wide props.
`mapistub.sln`	Updates VS version metadata and removes Prefast solution configurations.
`Directory.Build.props`	Introduces centralized toolset/SDK pin and baseline compiler/link security settings.
`.vsconfig`	Updates required SDK component to Windows 11 SDK 22621.
`.github/workflows/github-ci.yml`	Switches to a VS2026 runner label, adds ARM64EC to the build matrix, and installs Windows 11 SDK.
`.github/workflows/codeql.yml`	Switches to a VS2026 runner label, installs Windows 11 SDK, and updates CodeQL action SHAs.
`.github/workflows/scorecards.yml`	Updates `upload-sarif` action SHA.
`.github/workflows/devskim.yml`	Updates `upload-sarif` action SHA.
`.github/workflows/clang.yml`	Replaces the clang-format action with an apt-based install + manual formatting check script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/codeql.yml

mapistub.sln

.github/workflows/github-ci.yml

.github/workflows/codeql.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/codeql.yml

.github/workflows/github-ci.yml

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Directory.Build.props

.github/workflows/github-ci.yml

mapistub.sln

Directory.Build.props

.github/workflows/github-ci.yml

.github/workflows/codeql.yml

mapistub.vcxproj

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

mapistub.sln:24

The solution file is missing Fuzz configurations for Win32 and x64, but these configurations still exist in the mapistub.vcxproj file (lines 23-28, 103-109, 135-141). This inconsistency will prevent building Fuzz configurations from the solution. Either add Fuzz|Win32 and Fuzz|x64 to the solution file, or remove these configurations from the project file as well.

	GlobalSection(SolutionConfigurationPlatforms) = preSolution
		Debug_Unicode|x64 = Debug_Unicode|x64
		Debug_Unicode|Win32 = Debug_Unicode|Win32
		Debug_Unicode|ARM64 = Debug_Unicode|ARM64
		Debug_Unicode|ARM64EC = Debug_Unicode|ARM64EC
		Debug|x64 = Debug|x64
		Debug|Win32 = Debug|Win32
		Debug|ARM64 = Debug|ARM64
		Debug|ARM64EC = Debug|ARM64EC
		Release_Unicode|x64 = Release_Unicode|x64
		Release_Unicode|Win32 = Release_Unicode|Win32
		Release_Unicode|ARM64 = Release_Unicode|ARM64
		Release_Unicode|ARM64EC = Release_Unicode|ARM64EC
		Release|x64 = Release|x64
		Release|Win32 = Release|Win32
		Release|ARM64 = Release|ARM64
		Release|ARM64EC = Release|ARM64EC

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mapistub.sln

Directory.Build.props

.github/workflows/github-ci.yml

Directory.Build.props

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/codeql.yml

package.json

.github/workflows/clang.yml

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/github-ci.yml

.github/workflows/codeql.yml

package.json

.github/workflows/clang.yml

.github/workflows/github-ci.yml

.github/workflows/codeql.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…d update build docs

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/github-ci.yml

package.json

.github/workflows/github-ci.yml

…cripts

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-27T22:58:24Z

mapistub.vcxproj

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>


This file now has a UTF-8 BOM character before the XML declaration. That can create noisy diffs and occasionally trips tooling that expects the file to start with < immediately. If unintentional, consider removing the BOM to keep the project file consistent with other XML files in the repo.

Copilot · 2026-02-27T22:58:25Z

.github/workflows/github-ci.yml

+        $vsPath = & "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath
+        $msbuildPath = Join-Path $vsPath "MSBuild\Current\Bin\amd64\msbuild.exe"


The build step uses vswhere.exe without -requires Microsoft.Component.MSBuild and doesn’t validate that the computed MSBuild path exists. Adding the -requires filter (and a simple Test-Path check with a clear error) would make CI failures more diagnosable if the runner image changes.

Suggested change

$vsPath = & "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath

$msbuildPath = Join-Path $vsPath "MSBuild\Current\Bin\amd64\msbuild.exe"

$vswherePath = "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe"

if (-not (Test-Path $vswherePath)) {

Write-Error "vswhere.exe not found at expected path: $vswherePath"

exit 1

}

$vsPath = & $vswherePath -latest -requires Microsoft.Component.MSBuild -property installationPath

$msbuildPath = Join-Path $vsPath "MSBuild\Current\Bin\amd64\msbuild.exe"

if (-not (Test-Path $msbuildPath)) {

Write-Error "MSBuild not found at expected path: $msbuildPath (Visual Studio installation path: $vsPath)"

exit 1

}

Copilot · 2026-02-27T22:58:25Z

docs/Building.md

+The npm scripts now use MSBuild by default (and keep node-gyp scripts under `gyp:*`):



This section switches the default Node.js build path to MSBuild, but it doesn’t explicitly call out the new prerequisites (VS Build Tools/Visual Studio with MSBuild + the pinned Windows SDK version). Please update the Node.js build instructions here to mention the required VS/MSBuild + Windows SDK (10.0.22621.0) so users don’t hit opaque build failures.

Suggested change

The npm scripts now use MSBuild by default (and keep node-gyp scripts under `gyp:*`):

The npm scripts now use MSBuild by default (and keep node-gyp scripts under `gyp:*`).

**Prerequisites (in addition to Node.js):**

- Visual Studio 2019 or later **or** Visual Studio Build Tools with MSBuild and the C++ toolset installed (for example, the "Desktop development with C++" workload).

- Windows 10 SDK **10.0.22621.0** installed (the MSBuild-based scripts are pinned to this SDK version).

stephenegriffin added 4 commits February 6, 2026 13:22

ensure config

397ed25

install sdk

7a8ec30

update codeql

f8efc98

stephenegriffin mentioned this pull request Feb 6, 2026

Retarget platform toolset #163

Closed

stephenegriffin and others added 6 commits February 6, 2026 18:14

add arm builds

2405bc0

Merge branch 'main' into u/sgriffin/vc2026

f90d65c

update ci for arm

8e457ff

Remove Prefast configurations from mapistub

8c7b20d

Prefast analysis now enabled on-demand via MSBuild property (/p:EnablePREfast=true) instead of separate build configurations.

replace broken clang action

bba20d7

update clang action

14f70be

stephenegriffin enabled auto-merge February 17, 2026 22:43

stephenegriffin requested a review from Copilot February 17, 2026 22:44

Copilot started reviewing on behalf of stephenegriffin February 17, 2026 22:45 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

.github/workflows/codeql.yml Outdated Show resolved Hide resolved

mapistub.sln Outdated Show resolved Hide resolved

.github/workflows/github-ci.yml Outdated Show resolved Hide resolved

.github/workflows/codeql.yml Outdated Show resolved Hide resolved

stephenegriffin and others added 5 commits February 17, 2026 17:48

Update .github/workflows/codeql.yml

0f6a5a4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .github/workflows/codeql.yml

a0109fb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update mapistub.sln

4186348

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .github/workflows/github-ci.yml

eda8175

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix sdk installer

3c74dae

stephenegriffin requested a review from Copilot February 17, 2026 22:53

Copilot started reviewing on behalf of stephenegriffin February 17, 2026 22:53 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

.github/workflows/codeql.yml Outdated Show resolved Hide resolved

.github/workflows/github-ci.yml Outdated Show resolved Hide resolved

stephenegriffin requested a review from Copilot February 18, 2026 15:15

Copilot started reviewing on behalf of stephenegriffin February 18, 2026 15:24 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

better handling of sdk dependency

096a611

stephenegriffin requested a review from Copilot February 18, 2026 15:53

Copilot started reviewing on behalf of stephenegriffin February 18, 2026 15:59 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

stephenegriffin added 2 commits February 18, 2026 11:05

alternate attempt at sdk

8862bc8

better hash

8746341

stephenegriffin requested a review from Copilot February 18, 2026 16:14

Copilot started reviewing on behalf of stephenegriffin February 18, 2026 16:15 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

mapistub.sln Show resolved Hide resolved

Directory.Build.props Show resolved Hide resolved

.github/workflows/github-ci.yml Outdated Show resolved Hide resolved

Directory.Build.props Outdated Show resolved Hide resolved

Directory.Build.props Show resolved Hide resolved

stephenegriffin added 2 commits February 18, 2026 11:38

clean up project

d7186a2

add arm builds

b41fde2

stephenegriffin requested a review from Copilot February 18, 2026 21:01

Copilot started reviewing on behalf of stephenegriffin February 18, 2026 21:02 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

.github/workflows/codeql.yml Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

.github/workflows/clang.yml Show resolved Hide resolved

fix args

a5125bb

stephenegriffin requested a review from Copilot February 18, 2026 22:24

Copilot started reviewing on behalf of stephenegriffin February 18, 2026 22:25 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

stephenegriffin and others added 3 commits February 24, 2026 16:25

merge with main

9700f1f

Update .github/workflows/github-ci.yml

2b40870

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mapistub: harden msbuild scripts, fix CodeQL SDK failure handling, an…

5154baa

…d update build docs

stephenegriffin requested a review from Copilot February 27, 2026 22:28

Copilot started reviewing on behalf of stephenegriffin February 27, 2026 22:28 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

.github/workflows/github-ci.yml Show resolved Hide resolved

package.json Show resolved Hide resolved

package.json Show resolved Hide resolved

.github/workflows/github-ci.yml Outdated Show resolved Hide resolved

mapistub: dedupe SDK install in workflows and harden CI build/clean s…

de2788f

…cripts

stephenegriffin requested a review from Copilot February 27, 2026 22:54

Copilot AI reviewed Feb 27, 2026

View reviewed changes

		@@ -1,4 +1,4 @@
		<?xml version="1.0" encoding="utf-8"?>
		<?xml version="1.0" encoding="utf-8"?>

		$vsPath = & "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath
		$msbuildPath = Join-Path $vsPath "MSBuild\Current\Bin\amd64\msbuild.exe"

-        $vsPath = & "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath
-        $msbuildPath = Join-Path $vsPath "MSBuild\Current\Bin\amd64\msbuild.exe"
+        $vswherePath = "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe"
+        if (-not (Test-Path $vswherePath)) {
+          Write-Error "vswhere.exe not found at expected path: $vswherePath"
+          exit 1
+        }
+        $vsPath = & $vswherePath -latest -requires Microsoft.Component.MSBuild -property installationPath
+        $msbuildPath = Join-Path $vsPath "MSBuild\Current\Bin\amd64\msbuild.exe"
+        if (-not (Test-Path $msbuildPath)) {
+          Write-Error "MSBuild not found at expected path: $msbuildPath (Visual Studio installation path: $vsPath)"
+          exit 1
+        }

		The npm scripts now use MSBuild by default (and keep node-gyp scripts under `gyp:*`):

-The npm scripts now use MSBuild by default (and keep node-gyp scripts under `gyp:*`):
+The npm scripts now use MSBuild by default (and keep node-gyp scripts under `gyp:*`).
+**Prerequisites (in addition to Node.js):**
+- Visual Studio 2019 or later **or** Visual Studio Build Tools with MSBuild and the C++ toolset installed (for example, the "Desktop development with C++" workload).
+- Windows 10 SDK **10.0.22621.0** installed (the MSBuild-based scripts are pinned to this SDK version).

Conversation

stephenegriffin commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 27, 2026

github-actions bot commented Feb 6, 2026 •

edited

Loading