Skip to content

fix: merging dev to main#663

Merged
Avijit-Microsoft merged 6 commits into
mainfrom
dev
Jun 29, 2026
Merged

fix: merging dev to main#663
Avijit-Microsoft merged 6 commits into
mainfrom
dev

Conversation

@Priyanka1-Microsoft

Copy link
Copy Markdown

Purpose

  • ...
    This pull request updates default model names and capacities for quota checks, and standardizes Azure role assignments in the infrastructure code by replacing role names with their corresponding GUIDs. Documentation and sample commands are updated to reflect these changes.

Model and Capacity Updates:

  • Changed the default model from gpt-4o-mini to gpt4.1-mini and increased its default capacity from 100 to 150 in both quota_check_params.sh and related documentation. [1] [2] [3] [4]

Infrastructure Role Assignment Updates:

  • Replaced Azure role names with explicit GUIDs for all roleDefinitionIdOrName assignments in infra/main.bicep and the generated infra/main.json to ensure clarity and avoid ambiguity during deployment. This affects roles such as AcrPull, App Configuration Data Reader, Storage Blob Data Contributor, Search Index Data Contributor, Search Index Data Reader, Cognitive Services OpenAI Contributor, Cognitive Services OpenAI User, Cognitive Services User, and Contributor. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

Documentation and Sample Command Updates:

  • Updated docs/QuotaCheck.md to match the new default model name and capacity, ensuring consistency across documentation and code. [1] [2] [3]

Template Hash Update:

  • Updated the Bicep-generated template hash in infra/main.json to reflect the changes in the infrastructure code.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the quota-check defaults for the OpenAI model/capacity pair and standardizes Azure RBAC role assignment identifiers in the infrastructure templates by using explicit role definition GUIDs.

Changes:

  • Updated quota-check defaults to use gpt4.1-mini with capacity 150 (and aligned the QuotaCheck documentation examples).
  • Replaced RBAC role display names with role definition GUIDs in infra/main.bicep and regenerated infra/main.json accordingly.
  • Updated the generated template hash in infra/main.json.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
infra/main.bicep Switches role assignment inputs from role names to role definition GUIDs (with inline comments for readability).
infra/main.json Regenerated ARM template reflecting role GUID updates and updated template hash.
docs/QuotaCheck.md Updates default model/capacity examples to gpt4.1-mini:150.
Deployment/quota_check_params.sh Updates default model/capacity pair used by the quota-check script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/QuotaCheck.md
Comment thread Deployment/quota_check_params.sh
chore: Removing create-release.yml file
@Priyanka1-Microsoft

Copy link
Copy Markdown
Author
@microsoft-github-policy-service agree company="Microsoft"

@microsoft-github-policy-service agree company="Microsoft"

@Avijit-Microsoft Avijit-Microsoft merged commit 4abef72 into main Jun 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants