[WIP] Feature: Adding CMake support by LonghronShen · Pull Request #48 · microsoft/Detours

Steven Hangger (LonghronShen) · 2018-12-10T15:14:28Z

Try to add a simple CMakeLists.txt for building detours in x86/x64.
Support for other architectures like ARM/ARM64/IA64 may be added later.

Microsoft Contribution License Agreements (msftclas) · 2018-12-10T15:14:39Z

All CLA requirements met.

David Tarditi (dtarditi) · 2019-01-23T21:14:28Z

+ENDIF()
+
+FILE(GLOB detours_src
+    ${CMAKE_CURRENT_LIST_DIR}/src/*.h


Could you alphabetize the list of files here? I believe some source files are missing from the list. Also, please list out the header files - don't use the *.h pattern.

Thank you for your suggestions!
Since I'm not quite familiar with the Detours itself, I just use the script then it builded successfully. I will sort all these files here.
Then you're right, it is not nesscessary to add the header files. I'll remove the pattern, and use INCLUDE_DIRECTORIES instead.

David Tarditi (dtarditi) · 2019-01-23T21:15:29Z

Thanks for the proposed change. I have some suggestions.

Steven Hangger (LonghronShen) · 2019-01-26T14:39:03Z

Since the uimports.cpp file is included in creatwth.cpp#L347, I suggest that the uimports.cpp file should be renamed to uimports.h, then we can use *.cpp pattern to add all source files in the CMakeLists.txt.
CMakeLists.txt for samples are on the way.
OK, including .cpp files happens many times in the samples. Will this be changed in the future?

Marc Schlaich (schlamar) · 2019-02-04T10:18:07Z

It looks like Detours relies on build order of sources to compile reliable (AFAIS detours.cpp should be first). However, this is pretty bad as VS doesn't guarantee build order of source files.

I assume this is the reason your CMake file doesn't work for me. I guess your CMake configuration works for just one specific build order which I'm not getting on my machine. You are defining a lot of stuff which shouldn't be defined at all (e.g. DETOURS_VERSION, _X86_, DETOURS_X86, etc.).

Please note that the nmake Makefile is only passing /DWIN32_LEAN_AND_MEAN /D_WIN32_WINNT=0x501 to the compiler. (DETOURS_BITS=X is passed to rc.exe, but this is only relevant on building the examples).

My own CMake configuration is working with these two definitions, too. I have put detours.cpp at first entry in the source list. However, I'm not sure if this is reproducible or just luck.

I guess the correct approach would be to refactor Detours so it isn't dependent on build order anymore.

Steven Hangger (LonghronShen) · 2019-02-04T10:32:54Z

I can't agree more! My approach is now just for forcing to make specific platform work, to meet my basic need. I have been trying to do some research about the cross platform/architecture problem these days. We need a more uniform design.

David Tarditi (dtarditi) · 2019-05-15T22:24:35Z

Steven Hangger (@LonghronShen), what is the status of this change? We do need a cmake configuration to work for different developers. Are there dependencies missing from the cmake file that would better express the build order?

Steven Hangger (LonghronShen) · 2019-05-16T09:45:01Z

Now the PR has been done for the main project, and several other example projects.
What is still blocked is some example projects which involves some COM interops.
If this is not the key problem, I can update the PR and then I think we can merge the PR.

David Tarditi (dtarditi) · 2019-05-16T18:27:51Z

I think it is fine to exclude some samples for now from the cmake build. We can merge the PR and that can be worked on later. Please make sure it is documented that those samples don't have a cmake build yet.

Steven Hangger (LonghronShen) · 2019-05-16T18:42:11Z

CMake support

CMake support for the main project has been done for a while, but some sample projects are excluded for some interop reasons.

cping
disas
dtest
dumpe
dumpi
echo
einst
excep
findfunc
impmunge
member
opengl
slept
talloc
tryman

Other TODOs:

ARM/ARM64/IA64 support
Improve Sample project debugging experiences

David Tarditi (dtarditi) · 2019-05-16T20:11:05Z

Please let me know when this is ready for further review.

Steven Hangger (LonghronShen) · 2019-05-17T02:09:38Z

I think the current version is ready for review, except for these excluded sample projects.

Brian Gianforcaro (bgianfo) · 2020-09-02T06:29:34Z

+	LIST(APPEND DETOURS_COMPILE_DEFINITIONS "DETOURS_TARGET_PROCESSOR=X64")
+	LIST(APPEND DETOURS_COMPILE_DEFINITIONS DETOURS_X64)
+	LIST(APPEND DETOURS_COMPILE_DEFINITIONS DETOURS_64BIT)
+	LIST(APPEND DETOURS_COMPILE_DEFINITIONS _AMD64_)


The MSVC compiler sets these based on the architecture the configured compiler is targeting, the build system shouldn't be setting it them selves.

This is just imitating the actions written in Makefiles. Or can we change the code so that we can use modern ways to check these staffs?

Brian Gianforcaro (bgianfo) · 2020-09-02T06:30:49Z

+##
+
+## This file is based on the work of SimpleITK:
+##  https://github.com/SimpleITK/SimpleITK/blob/master/CMake/FindCSharp.cmake


We can't copy and paste code from other projects into Detours, this code has it's own LICENSE.

For this, I'll see if we can solve the problem by referencing the third party staffs as submodule or some other ways...

CMake 3.8+ has native support for C#
See: https://cmake.org/cmake/help/latest/release/3.8.html#id4

Brian Gianforcaro (bgianfo) · 2020-09-02T06:31:29Z

@@ -0,0 +1,79 @@
+CMAKE_MINIMUM_REQUIRED(VERSION 3.10)


Why is everything in all caps? can we fix it to be lower case?

As for older cmake code style, commands are written in UPPER CASE. Now it is year 2020, I'll change this.

I can run https://github.com/cheshirekow/cmake_format on the files if I can get push access to this PR.

Brian Gianforcaro (bgianfo) · 2020-09-02T07:06:32Z

Can you fix the merge conflicts in .gitignore?

Steven Hangger (LonghronShen) · 2020-09-02T07:14:40Z

OK, I'll take it in the next one or two days.

Brian Gianforcaro (bgianfo) · 2021-09-13T18:28:49Z

Preferably we should use a single build system for the entire project, because maintaining several is a maintenance burden more than anything else. Since CMake can generate Visual Studio solutions, maybe ditch nmake and the .sln?

Yup, completely agree, and that's why I haven't merged this yet.
I want it to be feature complete before we merge and use it the one true build system.
CMake can generate NMake as well, so there will be no reason to keep the nmake or sln after this is merged.

Deleted user (ghost) · 2021-09-20T23:00:50Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days.

defaultactor · 2026-05-18T07:09:50Z

last post was Sep 13, 2021, is this still an ongoing effort or has cmake been abandoned?

Successor to microsoft#48

Replaces the NMake Makefiles and vc/Detours.sln with a single CMake build covering the library, unit/integration tests, and every sample NMake built (opengl excluded, as NMake never built it either). find_package(Detours) is supported and tested against a real staged install, not just an in-tree build. .github/workflows/cmake.yml replaces main.yml's NMake-driven CI with a matrix across VS2022/VS2026, Ninja, x86/x64, Debug/Release, plus a real-hardware ARM64EC job, and keeps CodeQL coverage. NMake and the VS project are removed outright now that CMake has full parity, per the maintainer's own note that CMake would obsolete both: microsoft#48 (comment) Successor to microsoft#48

jpr42 · 2026-08-26T04:22:20Z

I've made #390 based on the feedback in this PR and my knowledge of modern CMake. I also did my best to add fair bit of testing.

We use detours in several projects for open source and at my company so we would like to get proper CMake support

jpr42 · 2026-08-26T04:24:19Z

last post was Sep 13, 2021, is this still an ongoing effort or has cmake been abandoned?

Looks like this effort was abandoned so I made a new one.

Preferably we should use a single build system for the entire project, because maintaining several is a maintenance burden more than anything else. Since CMake can generate Visual Studio solutions, maybe ditch nmake and the .sln?

Yup, completely agree, and that's why I haven't merged this yet. I want it to be feature complete before we merge and use it the one true build system. CMake can generate NMake as well, so there will be no reason to keep the nmake or sln after this is merged.

I've done my best to make the new CMake branch feature complete Brian Gianforcaro (@bgianfo)

jpr42 · 2026-08-26T04:24:56Z

I ran a fair bit of testing on my fork to make sure everything was working properly

jpr42 · 2026-08-26T04:25:06Z

As well as locally of course

Add CMakeLists.txt

7e398ed

Steven Hangger (LonghronShen) mentioned this pull request Dec 10, 2018

Added vc sln and vcxproj files #26

Closed

David Tarditi (dtarditi) reviewed Jan 23, 2019

View reviewed changes

sort source file list in the CMakeLists.txt and add a .gitignore file.

f182a9c

Steven Hangger (LonghronShen) changed the title ~~Add CMake support~~ [WIP] Adding CMake support Jan 26, 2019

Steven Hangger (LonghronShen) added 3 commits May 17, 2019 02:32

partial done for samples

91d8a31

exclude some sample projects for now

c6c57c9

Add documents for the CMake support.

4ff43ef

fix some typos

7525884

Brian Gianforcaro (bgianfo) requested a review from David Tarditi (dtarditi) August 17, 2020 17:58

Brian Gianforcaro (bgianfo) added the enhancement This adds new functionallity to the product label Aug 21, 2020

Charles Milette (sylveon) mentioned this pull request Aug 27, 2020

fix many bugs found by me, and reports by others in official repo. #127

Closed

Brian Gianforcaro (bgianfo) mentioned this pull request Aug 28, 2020

Ununderstandable documents (wiki) #49

Open

Brian Gianforcaro (bgianfo) reviewed Sep 2, 2020

View reviewed changes

Merge branch 'master' into master

510d11b

ghost added the status-no recent activity label Sep 20, 2021

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 17, 2026

Add CMake build support for MSVC alongside the existing NMake build

1289526

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 17, 2026

Add CMake build support for MSVC alongside the existing NMake build

2636cb1

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 17, 2026

Add CMake build support for MSVC alongside the existing NMake build

ec127ab

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 17, 2026

Add CMake build support for MSVC alongside the existing NMake build

57b6387

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 17, 2026

Add CMake build support for MSVC alongside the existing NMake build

82cb039

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 17, 2026

Add CMake build support for MSVC alongside the existing NMake build

d4e8942

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 17, 2026

Add CMake build support

1bfdd54

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 17, 2026

Add CMake build support

ba0e943

Successor to microsoft#48

jpr42 mentioned this pull request Aug 17, 2026

Add CMake build support and remove NMake/vc/.sln #390

Open

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 25, 2026

Add CMake build support

d0a2683

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 25, 2026

Add CMake build support

99dbba8

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 25, 2026

Add CMake build support

67b3f8d

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 25, 2026

Add CMake build support

7c855a6

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 25, 2026

Add CMake build support

c10a807

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 25, 2026

Add CMake build support

5138a2d

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 25, 2026

Add CMake build support

e08447c

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 26, 2026

Add CMake build support

0848680

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 26, 2026

Add CMake build support

f840ee3

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 26, 2026

Add CMake build support

46c43db

Successor to microsoft#48

jpr42 added a commit to jpr42/Detours that referenced this pull request Aug 26, 2026

Add CMake build support

c53a21c

Successor to microsoft#48

Uh oh!

Conversation

Steven Hangger (LonghronShen) commented Dec 10, 2018

Uh oh!

Microsoft Contribution License Agreements (msftclas) commented Dec 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Steven Hangger (LonghronShen) Jan 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

David Tarditi (dtarditi) commented Jan 23, 2019

Uh oh!

Steven Hangger (LonghronShen) commented Jan 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marc Schlaich (schlamar) commented Feb 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Steven Hangger (LonghronShen) commented Feb 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

David Tarditi (dtarditi) commented May 15, 2019

Uh oh!

Steven Hangger (LonghronShen) commented May 16, 2019

Uh oh!

David Tarditi (dtarditi) commented May 16, 2019

Uh oh!

Steven Hangger (LonghronShen) commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CMake support

Uh oh!

David Tarditi (dtarditi) commented May 16, 2019

Uh oh!

Steven Hangger (LonghronShen) commented May 17, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Steven Hangger (LonghronShen) Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brian Gianforcaro (bgianfo) commented Sep 2, 2020

Uh oh!

Steven Hangger (LonghronShen) commented Sep 2, 2020

Uh oh!

Brian Gianforcaro (bgianfo) commented Sep 13, 2021

Uh oh!

Deleted user (ghost) commented Sep 20, 2021

Uh oh!

defaultactor commented May 18, 2026

Uh oh!

jpr42 commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpr42 commented Aug 26, 2026

Uh oh!

jpr42 commented Aug 26, 2026

Uh oh!

jpr42 commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Microsoft Contribution License Agreements (msftclas) commented Dec 10, 2018 •

edited

Loading

Steven Hangger (LonghronShen) Jan 26, 2019 •

edited

Loading

Steven Hangger (LonghronShen) commented Jan 26, 2019 •

edited

Loading

Marc Schlaich (schlamar) commented Feb 4, 2019 •

edited

Loading

Steven Hangger (LonghronShen) commented Feb 4, 2019 •

edited

Loading

Steven Hangger (LonghronShen) commented May 16, 2019 •

edited

Loading

Steven Hangger (LonghronShen) Sep 2, 2020 •

edited

Loading

jpr42 commented Aug 26, 2026 •

edited

Loading