This repository was archived by the owner on Feb 9, 2024. It is now read-only.
Open
Conversation
abjinugu
commented
Apr 17, 2018
abjinugu
commented
- Added one more parameter in case of different paths for data and logs
- Checking if the path is of linux machine when SQL Server installed on Linux
1. Added one more parameter in case of different paths for data and logs 2. Checking if the path is of linux machine when SQL Server installed on Linux
|
|
kevcunnane
suggested changes
Apr 17, 2018
Contributor
kevcunnane
left a comment
kevcunnane
left a comment
There was a problem hiding this comment.
Thanks for your submission! There are 2 things to update and then we can take this PR.
- As mentioned in my other comment, logdatalocation should be optional so that for most cases the existing sample "just works".
- Please verify that all tests in TestDbLocationModifiers.cs still pass, and ideally add/edit an existing test to cover the new scenario of specifying the log data location. The change as-is should cause that test to fail.
2. Corrected indentation
Author
|
@kevcunnane , can you review this? |
|
@kevcunnane is this still being maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.