Fix cropped launcher icon - #94
Merged
Merged
Conversation
The adaptive icon foreground was the full-size logo, so launchers cropped it to the safe zone and it looked zoomed in. Added padded foreground/monochrome assets, regenerated the mipmaps, and pointed app.config.js at them. Splash still uses Offsides.png.
Owner
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adaptive icon foreground is the full-size logo, so launchers crop it to the safe zone (only the middle ~66dp of the 108dp canvas is guaranteed visible). On my OnePlus it shows up zoomed in with the edges cut off.
This adds padded foreground + monochrome PNGs with the logo at ~44% of the canvas, regenerates the mipmaps at every density, and points
app.config.jsat the new files so a futureexpo prebuildgives the same result.Offsides.pngis untouched and still used for the splash screen.