Skip to content

chore: Upgrade to Elixir 1.16 and Remove espec dependency#18

Open
abshierjoel wants to merge 1 commit into
meyercm:masterfrom
abshierjoel:update-for-elixir-16-otp-26
Open

chore: Upgrade to Elixir 1.16 and Remove espec dependency#18
abshierjoel wants to merge 1 commit into
meyercm:masterfrom
abshierjoel:update-for-elixir-16-otp-26

Conversation

@abshierjoel
Copy link
Copy Markdown

@abshierjoel abshierjoel commented Jan 24, 2024

Closes #17

This upgrades shorter_maps to support Elixir 1.16 with the following two changes:

  • The [line: line] pattern match is appears to be unreliable for the 2nd field of the tuple in sigil_m/2. This field sometimes comes back empty (which I would expect a failure, and sometimes includes column, which results in a false failure. I updated this to use a Keyword.get/3 rather than the match. If there's a better approach here, I'd appreciate the feedback.
  • I also updated the tests and removed the reliance on espec. It's hard for me to gleam the historic value of this library here, but to me it seems like ExUnit is complete enough to give nearly all of the desired behaviors (except doubly nested contexts). I opted to remove espec because it has yet to be updated to Elixir 1.16, and I think relying on just ExUnit will be more sustainable going forward.

@abshierjoel abshierjoel force-pushed the update-for-elixir-16-otp-26 branch 2 times, most recently from aca8d9a to 563f20c Compare January 24, 2024 20:50
@abshierjoel abshierjoel force-pushed the update-for-elixir-16-otp-26 branch from 563f20c to 5c4b246 Compare January 24, 2024 20:55
Copy link
Copy Markdown

@eatondustin1 eatondustin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This library is broken in elixir 1.16

2 participants