Repository navigation
[Nexthop][m4340nhp] Create ports the way the Qumran4D SAI requires - #1879
Open
marif-nexthop wants to merge 1 commit into
Open
marif-nexthop wants to merge 1 commit into
marif-nexthop wants to merge 1 commit into
Conversation
2 tasks done
marif-nexthop
force-pushed
the
marif.fboss-q4d-port-create
branch
from
October 31, 2026 01:48
ec68646 to
3ae8263
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Ports created at runtime, for example by a breakout, failed on Qumran4D for two reasons.
PortApi::_createpassedSAI_PORT_ATTR_TYPEtocreate_port. The attribute is read-only in the SAI spec and is in the DNX create attributes only so thatSaiStorecan tell port types apart. The Broadcom DNX SAI rejects it after creating the port, which leaves a half-created port that no retry can replace._createnow leaves aLOGICALtype out of the call and still passes the other types.create_port_serdeswithSAI_STATUS_ITEM_ALREADY_EXISTS. The newPORT_SERDES_CREATED_WITH_PORTfeature, set only for Qumran4D, makesSaiPortManageradopt that object, as it does on the other SAIs.Test Plan
On a
m4340nhpdevice with every cage broken out to 2x400G at init,AgentEmptyTest.CheckInitpasses on cold and warm boot. The changed files build in the OSS build, which does not compile the DNX-only branch.