Repository navigation
[Nexthop][m4340nhp] Default the Qumran4D CPU system ports - #1878
Open
marif-nexthop wants to merge 1 commit into
Open
marif-nexthop wants to merge 1 commit into
marif-nexthop wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Platforms defined by a platform descriptor, such as m4340nhp, load a plain
PlatformMappingwhosegetCpuPortsCoreAndPortIdx()is empty, so a Qumran4D switch on that path creates no CPU system ports.Qumran4DAsicnow falls back to the standard single-FAP layout when the platform supplies none. The layout has 17 CPU system ports, one per data path plus a third on core 0. Platforms with their own map, such as blackwolf800banw, keep it.Test Plan
On a
m4340nhpdevice, the agent comes up with this layout and brings up all 64 front-panel ports.switch_asicsbuilds in the OSS build.