Repository navigation
FIX: make terminal backgrounds consistent and approval buttons visible - #78
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Treat an empty NO_COLOR value as an explicit opt-out.
1 open finding
What changed in this PR
This PR standardizes terminal backgrounds, improves approval-button visibility, and adds Apple Terminal true-colour detection.
Changes:
- Adds explicit backgrounds across canvases, panels, editors, borders, and buttons.
- Adds approval-control styling and rendering regressions.
- Adds macOS Tahoe capability detection and documentation.
- Requires handling empty
NO_COLORvalues as an opt-out.
| File | Summary |
|---|---|
| README.md | Updates rendering and troubleshooting guidance. |
| main.go | Applies terminal-specific options. |
| main_terminal.go | Detects Apple Terminal true-colour support. |
| main_terminal_test.go | Tests capability detection. |
| main_terminal_other.go | Provides non-macOS fallback. |
| main_terminal_darwin.go | Detects supported macOS versions. |
| internal/ui/view.go | Paints canvas and panel backgrounds. |
| internal/ui/monitor.go | Applies button backgrounds. |
| internal/ui/monitor_suggestions.go | Paints suggestion-popup borders. |
| internal/ui/monitor_editor.go | Preserves editor tint backgrounds. |
| internal/ui/monitor_approval.go | Styles approval decision controls. |
| internal/ui/english_snapshot_test.go | Updates rendering snapshots. |
| internal/ui/background.go | Implements background filling. |
| internal/ui/background_test.go | Adds background and rendering regressions. |
| go.mod | Promotes rendering dependencies to direct requirements. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Apple Terminal could show patches of the profile background inside themed panels and buttons: nested text styles reset the background, borders used a separate default background, and unused screen cells retained the Terminal profile colour. These changes paint the intended theme backgrounds explicitly and give approval decisions solid, high-contrast fills.
The shared background fills and approval-button styling also change Windows appearance. Native Windows Terminal visual verification is still pending; font-dependent box-character seams may still vary.
Validation completed on macOS:
go test -race -cover -timeout 10m -skip '^TestLocalisedScreens$' ./...go test -race -cover -timeout 10m -run '^TestLocalisedScreens$' ./internal/uigo vet ./..., formatting andgit diff --checkmake buildand local binary version smoke checkWindows visual check before merge: build this branch, compare all themes and normal/hover/pressed button states, open an approval pill to inspect decision controls, and check editor/queue tints, resizing and inline rendering.