ci: trigger CI for PR #499 (add MiniMax provider)#514
Open
Conversation
Add MiniMax as a new LLM provider alongside OpenAI and Anthropic. MiniMax uses an OpenAI-compatible API with temperature clamping to (0.0, 1.0] and automatic stripping of think tags from reasoning model responses. Changes: - Add minimax_sdk.py with minimax_complete, temperature clamping, and think-tag stripping - Add get_minimax_async_client_instance in clients.py with default base URL https://api.minimax.io/v1 - Register minimax in FACTORIES mapping and update response_to_sendable_message to handle minimax SDK - Add minimax to CoreConfig.llm_sdk Literal type - Add 30 unit tests and 3 integration tests - Update docs with MiniMax setup example and README mention
…eneric think-tag stripping Removed the separate minimax_sdk.py, MiniMax provider enum, and dedicated client singleton. MiniMax is OpenAI-compatible, so users now configure it via LLM_SDK=openai + LLM_BASE_URL=https://api.minimax.io/v1. Added a generic _strip_think_tags() helper in openai_complete that benefits all reasoning models (MiniMax, DeepSeek, QwQ, etc.) by stripping <think>...</think> blocks from responses.
Address review feedback: stripping is now off by default and opt-in via the LLM_STRIP_TAGS env var (comma-separated tag names). This preserves raw LLM responses for downstream consumers while letting users who need stripping (e.g. for reasoning models) enable it explicitly. - Add llm_strip_tags: list[str] config field with comma-separated validator for env var support - Rename _strip_think_tags to generic _strip_tags(text, tags) - Apply stripping conditionally in openai_complete - Update tests to verify default-off and configured-on behavior - Document LLM_STRIP_TAGS env var in core settings docs
The regex in _strip_tags consumes trailing whitespace after the closing tag, so "before <think>...</think> after" becomes "before after" (single space), not "before after" (double space).
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary PR to trigger CI for fork PR #499. Will be closed after CI passes.