fix: use keyword arguments for Neo4jGraph initialization #4011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root cause: Neo4jGraph.__init__ parameter order is (url, username, password, token, database, ...) but the code passed database as the 4th positional argument, which maps to the token parameter. This caused the database value to be silently used as token, while the actual database defaulted to 'neo4j'. Fix: Use explicit keyword arguments to ensure each value maps to the correct parameter regardless of positional order.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3906.
Root cause:
Neo4jGraph.__init__parameter order is(url, username, password, token, database, ...)but the code passeddatabaseas the 4th positional argument, which maps totoken. This caused the database value to be silently used as token, while the actualdatabaseparameter defaulted to'neo4j'. Users configuring a non-default database name had it silently ignored.Fix: Use explicit keyword arguments for all parameters to ensure correct mapping regardless of positional order.
Changes
mem0/memory/graph_memory.py: ChangedNeo4jGraph()call from positional to keyword argumentsTesting
neo4jdatabase