fix: merge payload fields in MongoDB update instead of replacing #4010
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0ai#3966) Root cause: The update() method used $set with the entire payload object, which replaced all existing metadata fields. When updating memory content, custom metadata like bucket_id, context_id, category were completely lost. Fix: Use dot notation (payload.key) in $set to merge individual fields into the existing payload document, preserving unmodified metadata keys.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3966.
Root cause: The
update()method used{"$set": {"payload": payload}}which replaced the entirepayloaddocument. When updating memory content, all custom metadata fields (bucket_id,context_id,category,source, etc.) were completely lost.Fix: Use dot notation in
$setto merge individual fields:{"$set": {"payload.key1": val1, "payload.key2": val2}}. This preserves existing metadata keys that aren't being updated.Changes
mem0/vector_stores/mongodb.py: Changedupdate()to use dot notation for payload field updatesTesting