Reject undersized GBA ROM images - #2713
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
GBA ROM parsing read the game-code field at offset 0xAC before checking that the supplied image contained a complete GBA header. A crafted short ROM therefore caused an out-of-bounds host-memory read. Require a complete GBA header before parsing the image.
acts-1631
force-pushed
the
fix/gba-rom-minimum-length
branch
from
July 29, 2026 18:19
30c4e33 to
7e10aa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GBACart::ParseROM accepts any non-empty image, then immediately reads the
game-code field at offset 0xAC to detect solar-sensor titles. Images shorter
than the GBA header therefore reach a read beyond the allocated ROM buffer.
Require the input to contain a complete GBA header before padding or inspecting
header fields. This keeps malformed and truncated images out of the parser.