Add no_std feature to lmdb-master-sys #357
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional no_std feature that allows lmdb-master-sys to function as a no_std crate in POSIX environments that provide the file I/O syscalls required by LMDB. Changes: - Add no_std feature flag to Cargo.toml - Add conditional #![no_std] attribute to lib.rs - Replace all ::std::option::Option with ::core::option::Option in bindings.rs The feature is opt-in and maintains full backwards compatibility. When the no_std feature is not enabled, the crate behaves identically to before. The use of core::option::Option instead of std::option::Option is compatible with both std and no_std environments.
Kerollmops
requested changes
Jan 31, 2026
Member
Kerollmops
left a comment
Kerollmops
left a comment
There was a problem hiding this comment.
Thank you very much for the proposal, it looks great. However, I think I would also prefer that we update our bindgen usage, so I don't break it when updating the bindings next time.
Also, could you update lmdb-master3-sys, please? Probably the same way.
I am wondering about the complexity to add a CI to make sure I don't break it in the future 🤔
Update bindgen configuration to use .use_core() so future regeneration of bindings automatically uses core instead of std. This prevents the no_std support from breaking when bindings are regenerated. Also apply the same no_std changes to lmdb-master3-sys: - Add no_std feature flag to Cargo.toml - Add conditional #![no_std] attribute to lib.rs - Replace all ::std::option::Option with ::core::option::Option in bindings.rs
Author
|
Thanks for the quick response!
I pushed another commit that addressed bindgen and lmdb-master3-sys.
As for CI, I'm actually not familiar with Github CI (I just recently
escaped from Google into the real world after 15 years, so I'm learning a
lot about how these tools work), but if you can get it to run `cargo check
-p lmdb-master-sys --features no_std` (same for master3), that should be
sufficient.
…On Sat, Jan 31, 2026 at 1:32 AM Clément Renault ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thank you very much for the proposal, it looks great. However, I think I
would also prefer that we update our bindgen usage
<https://github.com/meilisearch/heed/blob/1262931497fc9fd7d47f6834288bca8fae832d93/lmdb-master-sys/build.rs#L112-L113>,
so I don't break it when updating the bindings
<https://github.com/meilisearch/heed/blob/1262931497fc9fd7d47f6834288bca8fae832d93/lmdb-master-sys/Cargo.toml#L19-L20>
next time.
Also, could you update lmdb-master3-sys, please? Probably the same way.
I am wondering about the complexity to add a CI to make sure I don't break
it in the future 🤔
—
Reply to this email directly, view it on GitHub
<#357 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BYMFV6LFJICVQMR5LASUYMT4JRSDNAVCNFSM6AAAAACTP3RMHOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOMZSGAZTMNRZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional no_std feature that allows lmdb-master-sys to function as a no_std crate in POSIX environments that provide the file I/O syscalls required by LMDB.
Changes:
The feature is opt-in and maintains full backwards compatibility. When the no_std feature is not enabled, the crate behaves identically to before. The use of core::option::Option instead of std::option::Option is compatible with both std and no_std environments.
Pull Request
Related issue
Fixes #356
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!