Open
Conversation
nothing0012
reviewed
Feb 20, 2024
| pool.payment_mint = args.payment_mint; | ||
| pool.allowlists = args.allowlists; | ||
|
|
||
| log_pool("post_create_pool", pool)?; |
Contributor
There was a problem hiding this comment.
we might have some indexing depends on this logging
Contributor
Author
There was a problem hiding this comment.
Yes, that's correct. The idea behind this PR is to change the way logging happens to avoid truncated logs causing misses on indexing, but it requires updating the indexing parser to handle the new logging method. So the indexing changes should be implemented before this PR is merged. @madergaser knows what needs to happen on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the program to use the Anchor
event_cpifeature for logging instead of the normal Solana logs which can get truncated by the validator.The two additional accounts caused stack overflow issues in the
mip1-sol-fulfill-buyaccounts struct, so to fix this:The removal of the rent account is a breaking change and required the client to be updated and any code consuming the client will need to be updated to no longer pass in the rent account.
Program logs before change:
Program logs after change:
Self-cpi:
