libgm: ignore is_old=true GaiaLoggedOut events from queue replay#53
Open
shafqatjamil wants to merge 1 commit intomautrix:mainfrom
Open
libgm: ignore is_old=true GaiaLoggedOut events from queue replay#53shafqatjamil wants to merge 1 commit intomautrix:mainfrom
shafqatjamil wants to merge 1 commit intomautrix:mainfrom
Conversation
libgm: ignore is_old=true GaiaLoggedOut events from queue replay The hackyLoggedOutBytes short-circuit in handleUpdatesEvent fired GaiaLoggedOut unconditionally, even for replayed queue events marked is_old=true. After a failed pair attempt, Google's per-account message queue retains orphan events including logout tombstones. On the next successful pair, those stale events are replayed to the new session and the bridge would self-unpair within ~1 second of "Successfully logged in." This aligns the logout path with the other branches in the same switch that already respect msg.IsOld. Fixes mautrix#52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libgm: ignore is_old=true GaiaLoggedOut events from queue replay
The hackyLoggedOutBytes short-circuit in handleUpdatesEvent fired GaiaLoggedOut unconditionally, even for replayed queue events marked is_old=true. After a failed pair attempt, Google's per-account message queue retains orphan events including logout tombstones. On the next successful pair, those stale events are replayed to the new session and the bridge would self-unpair within ~1 second of "Successfully logged in." This aligns the logout path with the other branches in the same switch that already respect msg.IsOld.
Fixes #52
Checklist