Fix device mismatch for residual weights in RBAPINN#614
Merged
Conversation
GiovanniCanali
added
bug
GiovanniCanali
force-pushed
the
fix_rba_pinn
branch
from
d578961 to
11bc203
Compare
GiovanniCanali
added
pr-to-review
FilippoOlivo
approved these changes
Jul 29, 2025
| # Compute normalized residuals | ||
| res = residuals[cond] | ||
| res_abs = res.abs() | ||
| res_abs = torch.linalg.vector_norm(res, ord=2, dim=1, keepdim=True) |
Collaborator
There was a problem hiding this comment.
Why is it changing from absolute value to norm l2?
Collaborator
Author
There was a problem hiding this comment.
This is done to ensure that the RBAPINN solver works also for a condition associated with a SystemEquation. Indeed, the weights' update must be a scalar.
Notice that when dealing with a single Equation, the L2 norm along the first dimension is the same as the absolute value.
Collaborator
Author
There was a problem hiding this comment.
GiovanniCanali
force-pushed
the
fix_rba_pinn
branch
from
11bc203 to
b2b2c35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #613.
Checklist