Skip to content

CI: fix some workflow issues#371

Merged
mbkma merged 3 commits intomasterfrom
ci-fixes
Jan 28, 2026
Merged

CI: fix some workflow issues#371
mbkma merged 3 commits intomasterfrom
ci-fixes

Conversation

@raveit65
Copy link
Member

No description provided.

@raveit65 raveit65 force-pushed the ci-fixes branch 2 times, most recently from 7414528 to 8f10bf2 Compare January 26, 2026 13:31
@raveit65
Copy link
Member Author

Archlinux (autotools) fails because of 9e9b24c, this check needs to be improved to avoid gi build errors.
Archlinux (meson) fails because gi build errors too, but here the check for newer introspection is missing.
Anyway, i don't know how to do it.

@raveit65 raveit65 changed the title CI: update NEWS which caused some workflow issues CI: fix some workflow issues Jan 26, 2026
@raveit65
Copy link
Member Author

After rebase only fixing gir for archlinux (meson) is left.
No idea to do that.

@vkareh
Copy link
Member

vkareh commented Jan 27, 2026

@raveit65 I added to this PR the same fix that I did to autotools but for meson. If this works I suspect we should be able to remove the -Dgdk-pixbuf-thumbnailer=false, but don't know yet for sure.

raveit65 and others added 2 commits January 27, 2026 08:54
 - gdk-pixbuf-thumbnailer is obsolete and should be replaced
   with glycin-thumbnailer
Fixes header conflicts on systems where glib has girepository-2.0 but
libpeas still uses the old gobject-introspection-1.0 headers.
@vkareh
Copy link
Member

vkareh commented Jan 27, 2026

No. Just tried arch without disabling the thumbnailer and it fails. I put the commit back in place and it should work for all distros now.

Copy link
Member

@vkareh vkareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow changes are correct and fix the pipelines.

@raveit65
Copy link
Member Author

I added to this PR the same fix that I did to autotools but for meson. If this works I suspect we should be able to remove the -Dgdk-pixbuf-thumbnailer=false, but don't know yet for sure.

@vkareh this is needed because gdk-pixbuf-thumbnailer is replaced with glycin-thumbnailer in very actual distros like fedora or archlinux. false means only that eom-thumbnailer will be built and use by eom.
Hope this is the same behavior with meson.
As a long term code should updated to use glycin-thumbnailer or not......... :)

@mbkma
Copy link
Member

mbkma commented Jan 28, 2026

@raveit65 was it intentional to push the NEWS file here?

@raveit65
Copy link
Member Author

News file was forgotten to update by previous (release 1.28.1) commit and pipeline failed.
Ie. https://github.com/mate-desktop/eom/actions/runs/21240176532/job/61116192246#step:8:3123
and other pipelines.

Copy link
Member

@mbkma mbkma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mbkma mbkma merged commit 92f1d8e into master Jan 28, 2026
10 checks passed
@mbkma mbkma deleted the ci-fixes branch January 28, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants