Skip to content

API_URL, API_TIMEOUT #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
donhardman merged 9 commits into from
Mar 26, 2026
Merged

API_URL, API_TIMEOUT #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cc00e97
ci: change DOCS_PER_CHUNK to constexpr, otherwise it won't compile in…
sanikolaev Dec 10, 2025
9e8b71c
chore: misc/build-libs-for-test-kit.sh
sanikolaev Dec 10, 2025
27553b4
feat!: API_URL and API_TIMEOUT support
sanikolaev Dec 10, 2025
a42941c
post-review fixes
glookka Jan 22, 2026
978b374
more post-review fixes
glookka Jan 22, 2026
5e1684a
more post-review fixes
glookka Jan 22, 2026
3879f7b
feat(embeddings): support unlimited timeout for API models
donhardman Mar 20, 2026
2eff35c
style(embeddings): format struct field declarations
donhardman Mar 20, 2026
302509f
chore(deps): bump manticoresearch to 0ed9a0d
donhardman Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion cmake/build_embeddings.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ function(build_embeddings_lib)
endif ()
endif ()

# Pass git commit and timestamp to build.rs via environment variables
# These variables are set by cmake/rev.cmake which is included in the main CMakeLists.txt
# The build.rs script uses these to generate a version string in the format:
# "VERSION commit@timestamp" (e.g., "1.1.0 38f499e@25112313")
# This matches the format used by other Manticore libraries for consistent version display
set(ENV{GIT_COMMIT_ID} "${GIT_COMMIT_ID}")
set(ENV{GIT_TIMESTAMP_ID} "${GIT_TIMESTAMP_ID}")

execute_process (
COMMAND cargo build --manifest-path ${CMAKE_SOURCE_DIR}/embeddings/Cargo.toml --lib --release --target-dir ${CMAKE_CURRENT_BINARY_DIR}/embeddings
RESULT_VARIABLE CMD_RESULT
Expand All @@ -51,7 +59,17 @@ function(build_embeddings_lib)
message ( FATAL_ERROR "Failed to build: ${CMD_RESULT}" )
endif ()

file(RENAME "${CMAKE_CURRENT_BINARY_DIR}/embeddings/release/${EMBEDDINGS_LIB_FILE_SRC}" "${CMAKE_CURRENT_BINARY_DIR}/embeddings/release/${EMBEDDINGS_LIB_FILE_DST}" )
set(EMBEDDINGS_LIB_SRC_PATH "${CMAKE_CURRENT_BINARY_DIR}/embeddings/release/${EMBEDDINGS_LIB_FILE_SRC}")
set(EMBEDDINGS_LIB_DST_PATH "${CMAKE_CURRENT_BINARY_DIR}/embeddings/release/${EMBEDDINGS_LIB_FILE_DST}")

# Check that the library file exists before attempting to rename it.
# This provides a clearer error message if EMBEDDINGS_LIB_NAME was not set correctly
# or if the cargo build produced a different filename than expected.
if (NOT EXISTS "${EMBEDDINGS_LIB_SRC_PATH}")
message ( FATAL_ERROR "Expected library file not found: ${EMBEDDINGS_LIB_SRC_PATH}" )
endif ()

file(RENAME "${EMBEDDINGS_LIB_SRC_PATH}" "${EMBEDDINGS_LIB_DST_PATH}")
if ( EXISTS "${CMAKE_CURRENT_BINARY_DIR}/embeddings/release/${EMBEDDINGS_LIB_NAME}.pdb" )
file(RENAME "${CMAKE_CURRENT_BINARY_DIR}/embeddings/release/${EMBEDDINGS_LIB_NAME}.pdb" "${CMAKE_CURRENT_BINARY_DIR}/embeddings/release/lib_${EMBEDDINGS_LIB_NAME}.pdb")
endif()
Expand Down
Loading
Loading