Bug: Footer.of_children omits width=100% on its outer table (#20)#22
Draft
makerprism-bot wants to merge 1 commit into
Draft
Bug: Footer.of_children omits width=100% on its outer table (#20)#22makerprism-bot wants to merge 1 commit into
makerprism-bot wants to merge 1 commit into
Conversation
9ec9a0d to
9a41e5d
Compare
Contributor
Expected (from PR title and issue #20)This PR should fix: "Footer.of_children omits width=100% on its outer table" Expected changes:
Actual (from PR diff)This PR actually changes:
What happened?This looks like a bot automation error - the diff from PR #21 (body_background feature) got applied to PR #22 (Footer width bug). Action neededPlease revert this branch and apply the correct diff from issue #20: (* lib/footer.ml - add width attribute to table *)
let of_children children =
[...]
make @@ builder
~tag:"table"
~attributes:[
"border", "0";
"cellpadding", "0";
"cellspacing", "0";
"role", "presentation";
"width", "100%"; (* <-- Add this *)
]
~children:[...]Reference issue #20 for the full requirements. |
Outlook for Windows requires the HTML width attribute (not CSS) on tables to prevent them from collapsing to content width. Without width="100%", Footer tables shrink to fit their text content and align unpredictably instead of spanning the full container width. This matches the pattern already used by Section, Callout, and Spacer, all of which emit width="100%" on their outer tables for the same reason. caniemail reference: https://www.caniemail.com/features/html-table/ Changes: - lib/footer.ml: Add "width", "100%" to table attributes - test/structure_tests.ml: Assert width=100% on both Footer paths - test/golden/footer.html: Update golden snapshot Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
9a41e5d to
b41bbc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
Automated implementation for issue #20 (#20).
Produced by automation run
34e0e9af-f5c3-45a6-b1f4-58168e0107c2using Claude Code onmakerprism/typemail.Agent's summary (last lines of output):
Review carefully; this is a first-attempt automated change.