Skip to content

MailjetTransport.php optimation #16

Description

@kevinveenbirkenbach

There are the following issues in the file MailjetTransport.php:

PHPDocs are wrong:

  • some @parameters are not declared
  • some @throws are not declared
  • some @returns contain not all possible return types
  • some @var use relative paths which can not be mapped by some IDE's e.g. (PHPStorm)

Logic:

  • There is some logic which is unnecessary in the function bulkSend

Variables:

  • $resultStatus is never used
  • $sendCount is double declared

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions