[codex] cover retry behavior for agent pack proxy routes#693
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR risk assessment
Risk level: Very Low
Decision: Approved (no additional reviewers required)
Evidence (from diff only)
| Signal | Finding |
|---|---|
| Files changed | 2 — both *.test.ts |
| Production code | None |
| Lines | +48 (test assertions only) |
| Infra / auth / schema | None |
What changed
web/app/proxy-routes.test.ts— Adds parameterized cases so/agent-packs/claudeand/agent-packs/claude/downloadproxy wiring is covered like other backend routes.web/lib/server/backendProxy.test.ts— Adds a test that network errors on binary download paths are retried, the response stays streaming (arrayBuffernot called), andx-promptc-proxy-attemptsreflects the retry count.
Why Very Low
- Test-only diff with no runtime behavior change
- Narrow scope: proxy route wiring + existing retry helper behavior
- Low blast radius; easy to reason about correctness
Reviewers
- No domain reviewers assigned by this automation (Very Low threshold).
- GitHub Copilot review already requested (1 bot reviewer; under the 2-reviewer cap).
CODEOWNERS
No CODEOWNERS file in repo; no blocking owner review detected.
Slack summary
PR #693 — [codex] cover retry behavior for agent pack proxy routes
Repo: madara88645/Compiler
Branch: codex/proxy-retry-agent-packs → main
Risk: Very Low
Action: Approved (automation)
Reviewers added: None
Notes: Test-only (+48 lines). Covers agent-pack proxy routes and binary-download retry/streaming behavior. No production code changes.
URL: https://github.com/madara88645/Compiler/pull/693
Sent by Cursor Automation: Assign PR reviewers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/agent-packs/claude/agent-packs/claude/downloadWhy this changed
These routes were recently opted into retry-on-wakeup behavior, but the regression tests did not cover the agent pack create/download flows. This PR locks that behavior in so a later refactor does not quietly remove it.
Product impact
Users are less likely to see flaky first-load failures on agent pack create and download flows, and we now have tests that catch regressions before they ship.
Verification
cd web && npx vitest run app/proxy-routes.test.ts lib/server/backendProxy.test.tscd web && npm run test:contracts