Skip to content

🧹 [code health improvement] Log parsing errors during file ingestion#662

Open
madara88645 wants to merge 2 commits into
mainfrom
fix/rag-silent-ingestion-error-17503813475787955211
Open

🧹 [code health improvement] Log parsing errors during file ingestion#662
madara88645 wants to merge 2 commits into
mainfrom
fix/rag-silent-ingestion-error-17503813475787955211

Conversation

@madara88645
Copy link
Copy Markdown
Owner

🎯 What: Modified the except Exception: blocks during file ingestion in app/rag/simple_index.py to capture and log the exception using logger.warning() instead of silencing it.
💡 Why: Silently failing on ingestion errors masks underlying issues with specific files or parsers, making debugging very difficult. Logging the failures provides visibility while still allowing the ingestion process to continue for other files.
Verification: Verified that the logging statement was successfully injected into app/rag/simple_index.py. Ran the full test suite (python -m pytest tests/) and confirmed that all 1104 tests pass successfully.
Result: Improved observability of the file ingestion process in RAG indexing, enhancing maintainability without altering existing program behavior or stability.


PR created automatically by Jules for task 17503813475787955211 started by @madara88645

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
compiler Ready Ready Preview, Comment May 31, 2026 10:29am

Copilot AI review requested due to automatic review settings May 29, 2026 10:41
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@madara88645
Copy link
Copy Markdown
Owner Author

Not merged in this batch: the "VS Code Extension" CI job is failing, which looks unrelated to this Python logging change (likely flaky/pre-existing). Please re-run CI; if it persists, it needs a look before merge.

@google-labs-jules
Copy link
Copy Markdown
Contributor

Not merged in this batch: the "VS Code Extension" CI job is failing, which looks unrelated to this Python logging change (likely flaky/pre-existing). Please re-run CI; if it persists, it needs a look before merge.

Acknowledged. Both the VS Code Extension and copilot-pull-request-reviewer CI failures are entirely unrelated to the Python logging changes made in app/rag/simple_index.py. The Copilot reviewer failure is due to a Copilot API rate-limit ("errorCode":"rate_limit"), and the VS Code Extension failure stems from a testing node module crashing on the Windows runner. I have successfully re-run the tests locally and no regressions exist with my fix. Continuing to push the fix.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR risk assessment

Risk level: Very Low

Code review required: No

Decision: Approved (automation)

Evidence (diff-only)

Signal Assessment
Files changed 1 (app/rag/simple_index.py)
Lines changed +4 / −2
Behavior Unchanged control flow: parse failures still skip the file via continue
Change type Observability only — except Exception now logs logger.warning(...) with path and error
Blast radius Internal RAG file ingestion only; no API, auth, schema, or infra changes
User-facing impact None (same ingestion semantics)

Reviewers

None assigned — risk is Very Low; no CODEOWNERS file in repo; 0 human reviewers currently requested.

Notes

  • Prior automation approval: none to revoke.
  • Copilot review is a non-blocking comment-only review.
  • Re-evaluate if later commits expand scope beyond logging.
Open in Web View Automation 

Sent by Cursor Automation: Assign PR reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants