Fix setState() called after dispose in MacosPulldownButton - #581
Closed
Abbas1Hussein wants to merge 7 commits into
Closed
Fix setState() called after dispose in MacosPulldownButton#581Abbas1Hussein wants to merge 7 commits into
Abbas1Hussein wants to merge 7 commits into
Conversation
Fix setState() called after dispose in.
Collaborator
|
Hey @Abbas1Hussein, thanks for the PR. This is currently blocked by #580. In the meantime:
|
Contributor
Author
|
Updated the PR as requested:
All tests are passing successfully. Thanks for the feedback! |
Collaborator
|
Looks like you deleted the changelog, can you please undo that? |
Contributor
Author
|
I removed the file while cleaning up my branch, I’ve restored the CHANGELOG.md file. Please let me know if anything else is needed. |
Collaborator
It looks like the file was not restored completely - if you look at the diff on this PR, you will see several recent entries are showing as removed. Please add those back in. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: avoid calling setState after dispose in MacosPulldownButton
When I used
MacosPulldownButton, this error appeared during tests:It happened because
setStatewas called inside thenavigator.push(...).then(...)callback after the widget was already disposed.I fixed it by adding a mounted check before calling
setState: