Repository navigation
Add snapshot comparisons to graph row rendering tests - #193
Merged
Merged
Conversation
Move decoded-pixel comparison, actual PNG saving and mismatch output into test support, and use it from graph snapshots. Missing snapshots report their expected path and the saved actual image. All 29 graph tests pass against their existing snapshots.
Compose row images without overwriting cell boundaries, and save a separate cloned image with red borders under the _borders suffix. Preserve the existing row order. All 42 rendering cases run successfully. Diagnostic images match raw images outside the cell borders.
Add reviewed expectations for seven parameter variants across three styles, with and without antialiasing. Compare decoded pixels before border overlays and keep border diagnostics available when a comparison fails. All 42 cases pass. End-to-end checks reject boundary-pixel, alpha and dimension differences and missing snapshots; different PNG metadata with identical pixels passes.
Describe the row rendering test filter, expected image directory and separate raw, bordered and diff outputs. Show how to copy a reviewed rendered image into the snapshot directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.