Open
Conversation
Collaborator
|
👍，代码优化了很多。现在已经有一个gradle3.0.0分支，已经做了gradle升级，并且我写了一篇文章http://www.jianshu.com/p/c7459b59dcd5。不过你的代码优化还是挺好的，一些细节我的确注意不够，建议将代码优化和gradle升级分拆开，代码升级部分提交到master分支，gradle升级提交到gradle3.0.0分支 |
Author
|
@mqzhangw 后面才注意到已经有3.0的分支了。多谢哈 |
Contributor
|
上次有个issue还准备写一下gradle plugin3.0.0 迁移的，发现有分支之后就一直没动手 233🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
公司项目的环境是3.0的最新环境，所以在这个库的基础上做了3.0的迁移。
并且也把代码贡献出来，感谢楼主的开源