Harden Redis store semantics and align CI/tooling#3
Merged
jwoertink merged 3 commits intoluckyframework:mainfrom Mar 24, 2026
Merged
Harden Redis store semantics and align CI/tooling#3jwoertink merged 3 commits intoluckyframework:mainfrom
jwoertink merged 3 commits intoluckyframework:mainfrom
Conversation
Member
|
Nice! For that failure on 1.16, Timecop has to be locked to v0.5.0 I think. They made a change that requires Crystal 1.19 or later. If you can just add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shard needed a big refresh.
About luckyframework/lucky_cache#17 :
This shard already supports those same array/basic types:
lucky_cache_redis_store/redis_store.cr:222, and src/lucky_cache_redis_store/redis_store.cr:271
lucky_cache_redis_store/redis_store_spec.cr:137
The important caveat is that it is not identical to MemoryStore overall: