Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
luaVersion: ["5.1.5", "5.2.4", "5.3.5", "5.4.8", "5.5.0", "luajit-2.0.5", "luajit-2.1.0-beta3", "luajit-openresty", "5.1"]

luaVersion: ["5.1.5", "5.2.4", "5.3.5", "5.4.8", "5.5.1", "luajit", "luajit-openresty", "5.1"]

runs-on: ubuntu-latest

Expand Down
16 changes: 2 additions & 14 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,11 @@ jobs:
strategy:
fail-fast: false
matrix:
luaVersion: ["5.1.5", "5.2.4", "5.3.6", "5.4.8", "5.5.0", "luajit", "luajit-2.0", "luajit-2.1", "luajit-2.0.5", "luajit-2.1.0-beta3", "luajit-openresty", "5.1", "5.4", "5.5"]
luaVersion: ["5.1.5", "5.2.4", "5.3.6", "5.4.8", "5.5.1", "luajit", "luajit-2.0", "luajit-2.1", "luajit-openresty", "5.1", "5.5"]
machineTag: ["ubuntu-latest", "macos-latest", "windows-latest"]
exclude:
- luaVersion: "luajit-2.0"
machineTag: "macos-latest"
- luaVersion: "luajit-2.0.5"
machineTag: "macos-latest"
- luaVersion: "luajit-2.0.5"
machineTag: "windows-latest"
- luaVersion: "luajit-2.1.0-beta3"
machineTag: "windows-latest"

runs-on: ${{ matrix.machineTag }}

Expand All @@ -47,17 +41,11 @@ jobs:
strategy:
fail-fast: false
matrix:
luaVersion: ["5.1.5", "5.2.4", "5.3.6", "5.4.8", "5.5.0", "luajit", "luajit-2.0", "luajit-2.1", "luajit-2.0.5", "luajit-2.1.0-beta3", "luajit-openresty", "5.1", "5.4", "5.5"]
luaVersion: ["5.1.5", "5.2.4", "5.3.6", "5.4.8", "5.5.1", "luajit", "luajit-2.0", "luajit-2.1", "luajit-openresty", "5.1", "5.5"]
machineTag: ["ubuntu-latest", "macos-latest", "windows-latest"]
exclude:
- luaVersion: "luajit-2.0"
machineTag: "macos-latest"
- luaVersion: "luajit-2.0.5"
machineTag: "macos-latest"
- luaVersion: "luajit-2.0.5"
machineTag: "windows-latest"
- luaVersion: "luajit-2.1.0-beta3"
machineTag: "windows-latest"

runs-on: ${{ matrix.machineTag }}

Expand Down
22 changes: 11 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,26 +19,26 @@ Other Lua GitHub actions:

## Usage

Install Lua: (Will typically default to the latest release, 5.5.0 as of this readme)
Install Lua: (Will typically default to the latest release, `5.5.1` as of this readme)

```yaml
- uses: luarocks/gh-actions-lua@v12
- uses: luarocks/gh-actions-lua@v13
```

Install specific version of Lua:

```yaml
- uses: luarocks/gh-actions-lua@v12
- uses: luarocks/gh-actions-lua@v13
with:
luaVersion: "5.1.5"
```

Install specific version of LuaJIT:

```yaml
- uses: luarocks/gh-actions-lua@v12
- uses: luarocks/gh-actions-lua@v13
with:
luaVersion: "luajit-2.1.0-beta3"
luaVersion: "luajit-2.0"
```

When using Windows the following prerequisite action must be run before
Expand All @@ -47,7 +47,7 @@ include this line on non-Windows platforms, as the action will do nothing in tho

```yaml
- uses: step-security/msvc-dev-cmd@v1
- uses: luarocks/gh-actions-lua@v11
- uses: luarocks/gh-actions-lua@v13
```

## Inputs
Expand Down Expand Up @@ -91,7 +91,7 @@ Additional flags to pass to `make` when building Lua.
Example value:

```yaml
- uses: luarocks/gh-actions-lua@v12
- uses: luarocks/gh-actions-lua@v13
with:
luaVersion: 5.3
luaCompileFlags: LUA_CFLAGS="-DLUA_INT_TYPE=LUA_INT_INT"
Expand All @@ -118,7 +118,7 @@ jobs:
steps:
- uses: actions/checkout@v7

- uses: luarocks/gh-actions-lua@v12
- uses: luarocks/gh-actions-lua@v13
with:
luaVersion: "5.1.5"

Expand All @@ -136,7 +136,7 @@ jobs:

This example:

* Uses Lua 5.1.5 — You can use another version by chaning the `luaVersion` varible. LuaJIT versions can be used by prefixing the version with `luajit-`, i.e. `luajit-2.1.0-beta3`
* Uses Lua 5.1.5 — You can use another version by changing the `luaVersion` variable. LuaJIT versions from known branches (`master`, `v2.1` or `v2.0`) can be used by prefixing the version with `luajit-`, i.e. `luajit-2.0`
* Uses a `.rockspec` file the root directory of your repository to install dependencies and test packaging the module via `luarocks make`


Expand All @@ -151,11 +151,11 @@ jobs:
test:
strategy:
matrix:
luaVersion: ["5.1.5", "5.2.4", "luajit-2.1.0-beta3"]
luaVersion: ["5.1.5", "5.2.4", "luajit"]

steps:
- uses: actions/checkout@v7
- uses: luarocks/gh-actions-lua@v12
- uses: luarocks/gh-actions-lua@v13
with:
luaVersion: ${{ matrix.luaVersion }}

Expand Down
7 changes: 1 addition & 6 deletions main.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const VERSION_ALIASES = {
"5.2": "5.2.4",
"5.3": "5.3.6",
"5.4": "5.4.8",
"5.5": "5.5.0",
"5.5": "5.5.1",
"luajit": "luajit-2.1",
}

Expand All @@ -33,11 +33,6 @@ const LUAJIT_REPOS = {
"branch": "v2.1",
"binary": "luajit"
},
"luajit-2.1.0-beta3": {
"url": "https://github.com/luajit/luajit.git",
"branch": "v2.1.0-beta3",
"binary": "luajit-2.1.0-beta3"
},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one could be a breaking change for people. But I assume they could change it to luajit-2.1 and get (mostly?) equivalent behavior.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to install LuaJIT 2.1.0-beta3 was failing for users as well (see lunarmodules/copas#197).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, deleting tags is a pretty nuclear option for making people upgrade.

But the Lua community, ever since the Lua/LuaJIT split around 5.2 (gosh, that was... 15 years ago!?), has gotten in this paralyzing tendency of supporting old versions forever, even when upstream doesn't support them anymore. We should really be (gradually?) moving into supporting only the latest PUC-Rio Lua and the latest LuaJIT, at best.

If people want to be using very very old versions of Lua, they should be using very very old versions of the supporting ecosystem as well, and not forcing maintainers into supporting 20+ years of legacy at all times.

"luajit-master": {
"url": "https://github.com/luajit/luajit.git",
"branch": "master",
Expand Down
Loading