refactor: merge review overview into a single Findings table - #22
Merged
Conversation
Replace the separate 'Since last review' and 'What to do next' sections with one ## Findings table (status/severity/finding) so each finding appears once. Status column renders only on re-reviews; resolved rows are struck through. Drop the PR title from the overview prose. Remove the now unused concern_for_finding helper and FindingProgress::is_empty. Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
Codasaurus
refactor: merge review overview into a single Findings table This PR updates 4 files across What to do next
Copy this into your AI coding agentPaste this prompt into Cursor, Copilot, or another coding agent: Changes
All files (4)
|
ContextRelated pull requests
|
ChecksBefore merge
Reviewer time ~20 min (3/5 · Moderate · 4 files) CommandsType as plain text (GitHub Apps are not @-mentionable):
Full list: |
This was referenced Aug 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the review overview comment. Before, a re-review listed the same findings three times: in the prose count, in "Since last review" (Resolved / Still open / New bullets), and again in "What to do next" (Please check [concern] checklist).
Now there is a single Findings table where each finding appears exactly once.
Before (re-review):
After:
Also drops the PR title from the overview prose (it is already shown by GitHub above the comment), and removes two now-unused helpers (concern_for_finding, FindingProgress::is_empty).
No behavior change to the checks themselves, the Changes table, or the collapsed agent prompt. All lib tests pass, clippy -D warnings and fmt are clean.