Skip to content

refactor: merge review overview into a single Findings table - #22

Merged
lohitkolluri merged 1 commit into
mainfrom
feat/review-comment-redesign
Aug 2, 2026
Merged

refactor: merge review overview into a single Findings table#22
lohitkolluri merged 1 commit into
mainfrom
feat/review-comment-redesign

Conversation

@lohitkolluri

Copy link
Copy Markdown
Owner

Consolidates the review overview comment. Before, a re-review listed the same findings three times: in the prose count, in "Since last review" (Resolved / Still open / New bullets), and again in "What to do next" (Please check [concern] checklist).

Now there is a single Findings table where each finding appears exactly once.

Before (re-review):

  • Since last review
    • Resolved: Repeated code in src/bot/mod.rs
    • Still open: Repeated code in src/bot/threads.rs
    • Still open: Repeated code in src/bot/worker.rs
  • What to do next
    1. Please check [quality]: Repeated code in src/bot/mod.rs
    2. Please check [quality]: Repeated code in src/bot/threads.rs
    3. Please check [quality]: Repeated code in src/bot/worker.rs

After:

  • Findings table with Status (new / open / resolved), Severity, and Finding columns
    • Resolved rows are struck through
    • Status column only appears on re-reviews; first reviews keep a lean two-column table
    • Sorted by severity, resolved rows at the bottom

Also drops the PR title from the overview prose (it is already shown by GitHub above the comment), and removes two now-unused helpers (concern_for_finding, FindingProgress::is_empty).

No behavior change to the checks themselves, the Changes table, or the collapsed agent prompt. All lib tests pass, clippy -D warnings and fmt are clean.

Replace the separate 'Since last review' and 'What to do next' sections
with one ## Findings table (status/severity/finding) so each finding
appears once. Status column renders only on re-reviews; resolved rows are
struck through. Drop the PR title from the overview prose. Remove the now
unused concern_for_finding helper and FindingProgress::is_empty.

Signed-off-by: Lohit Kolluri <lohitkolluri@gmail.com>
@codasaurus-e0a6

Copy link
Copy Markdown

Codasaurus

BLOCKING: 0 WARNING: 1 INFO: 0 READY TO MERGE: NO

Advisory draft — soft findings only. Codasaurus will not request changes; a maintainer still decides merge.

refactor: merge review overview into a single Findings table

This PR updates 4 files across src, (root). I spotted 1 thing worth a quick look (not blockers). See the list below.

What to do next

  1. Please check [quality]: Repeated code in src/bot/markdown.rs
Copy this into your AI coding agent

Paste this prompt into Cursor, Copilot, or another coding agent:

You are fixing Codasaurus review findings on a GitHub pull request.

## Rules
- Change only what is required to resolve the findings below.
- Do not refactor unrelated code or add features.
- Prefer the smallest correct diff.
- `tests/fixtures/golden/` and `golden/*/input.*` files intentionally contain sample secrets/TODOs for detector tests — do not "fix" those unless the PR is explicitly changing the fixture contract.
- Workspace crate imports in `tests/` (e.g. `use codasaurus::…`) are expected — do not add them to Cargo.toml.
- If a finding is a false positive, say so instead of changing code.
- After edits, summarize what you changed and why.

## Findings (priority order)
### 1. [warning] Repeated code
- **Location:** `src/bot/markdown.rs`
- **Detector:** `boilerplate`
- **Issue:** Repeated code blocks found (4 instances) — AI often generates repetitive code.
- **Fix:** Extract repeated blocks into reusable functions.


## PR context
Title: refactor: merge review overview into a single Findings table

Changes

Path What changed
CHANGELOG.md updated
src/bot/concern.rs updated
src/bot/markdown.rs updated
src/bot/review/pipeline.rs updated
All files (4)
  • CHANGELOG.md (modified)
  • src/bot/concern.rs (modified)
  • src/bot/markdown.rs (modified)
  • src/bot/review/pipeline.rs (modified)

@codasaurus-e0a6

Copy link
Copy Markdown

Context

Related pull requests

@codasaurus-e0a6

Copy link
Copy Markdown

Checks

Before merge

  • No blocking findings
  • Warning budget within limit
    • At most 0 warnings allowed. Clear the notes on the Files tab, or ask a teammate.
  • PR has a title

Reviewer time ~20 min (3/5 · Moderate · 4 files)

Commands

Type as plain text (GitHub Apps are not @-mentionable):

review · describe · summarize · improve · security · ask … · ignore <fp> · help

Full list: @codasaurus help

@codasaurus-e0a6 codasaurus-e0a6 Bot added the documentation Improvements or additions to documentation label Aug 2, 2026
@lohitkolluri
lohitkolluri merged commit 6897e4f into main Aug 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant