Accelerate and torchrun launcher support#10
Open
bghira wants to merge 1 commit into
Open
Conversation
Owner
|
im still working on torch run stuff, because if you call torch run naively the state wont get shared and you will end up with duplicate copies and non of the state are updating each other. i don't think it can be run natively using torch run tbh because you have to run it as a spawned child to shared common CPU buffer ideally we want more elegant solution than just raw bypass 🤔 |
Author
|
yes, it's using shared memory handles to pass the data to the subsequent ranks, and only falls back to the inelegant approach if SHM isn't available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what & why
change details
the mps-compatible path is added so that development on ramtorch can be done even when on unified architecture.
i've got a monkeypatch version of this for my trainer that patches ramtorch at runtime, so if you're not comfortable including these changes, it's not a big deal - but it would be very nice to support more broad adoption of ramtorch for multigpu/multinode training.