Fix fb deletion priority#650
Merged
Merged
Conversation
Goes through batchAction based on the priority order set by us, that is first try to delete all items. If there are 0 checked item with batchAction set as delete, then try to untag, and then try to hide. These prevents anomalies where the first item might have just "hide" action since it will always try to delete all items first and only move to next priority action if there is 0 checked item.
… still deletes the second item
SaptakS
force-pushed
the
fix-fb-deletion-priority
branch
from
40aa938 to
e65ec5e
Compare
micahflee
requested changes
Apr 15, 2026
Member
micahflee
left a comment
micahflee
left a comment
There was a problem hiding this comment.
This works great! I think we should add two additional things to this PR:
- Separate the progress into items deleted, untagged, and hidden, instead of just deleted. (This will also require a small
cyd-serverchange, when submitting progress.) - Display more verbose progress info, possibly in the speech bubble? Instead of just saying "I'm removing all posts from your Facebook wall." it should give granular updates:
- When it starts looping through a different action, it should say something like, "I'm looking for a batch of posts to delete/untag/hide..."
- After it finds a batch, it should say something like, "I'm deleting/untagging/hiding X posts..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649
This PR does things slightly differently from the approach listed in the issue.
This does make things slightly slower than before, but I think classifying (as suggested in the issue) would make it equally slow. I have added some test to replicate the issue and also tried to replicate the issue in a test account and in both cases, it seems to work. We may have to brainstorm later if we can improve performance, but this definitely seems to be working in deleting, untagging and hiding everything.
I think this process is also easier, if we want to provide a better summary of how many elements were deleted, how many were untagged and how many were hidden.