Merged
Conversation
bentsku
force-pushed
the
fix-enum-validation
branch
from
4fdc8c1 to
94b26a3
Compare
giograno
approved these changes
Feb 6, 2026
Member
giograno
left a comment
giograno
left a comment
There was a problem hiding this comment.
Nice one :D kudos for removing packaging as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an issue with Enum symbols which would contain ..
This is because the base avro validation also use the validation for validating full names, which allow . characters.
I've used the same validation as fastavro, as this is what we use to encode/decode data, to make sure the validation will pass 👍
Also fixed a test due to CI error which probably stem from an update in
packaging.version:class PyType(packaging.version.Version, str): ...has a type conflict