Conversation
bentsku
left a comment
bentsku
left a comment
There was a problem hiding this comment.
Nice, this looks great! A nice clean up 🧹
I have a few questions in comments, and I'm not sure I'm fully aware of all the best practices when it comes to packaging/library we provide and how we want that to look like.
A lot of the PR is type clean up after fixing this library to 3.13 too 😄
|
|
||
| # This workflow will upload a Python Package using Twine when a release is created | ||
| # For more information see: https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#publishing-to-package-registries | ||
| # This workflow will install Python dependencies, run tests and lint with a variety of Python versions |
There was a problem hiding this comment.
question: I guess this workflow still releases a new package, right? This is not mentioned anymore
There was a problem hiding this comment.
question: should we keep precommit, but maybe use the same as LocalStack? ruff, etc?
| "Download" = "https://pypi.python.org/pypi/py-avro-schema" | ||
| "Source Code" = "https://github.com/localstack/py-avro-schema" | ||
|
|
||
| [tool.ruff] |
There was a problem hiding this comment.
nit: I wonder if we should move the [tool...] parts under the dependency parts, so that they are visible first and and they are "top-level" fields?
|
|
||
| install: | ||
| uv venv --clear | ||
| uv sync --no-dev |
There was a problem hiding this comment.
interesting new API 😄 I haven't really used uv yet, but I guess this is somewhat compatible with the pip commands. I wonder which direction we're going to go for LS!
2 participants
This PR aims at simplifying/modernizing the dev UX and the project structure. In particular:
toxwithuvfor Package management.rufffor formatting & linting;