ec2: Enhance fleet creation with LaunchTemplateAndOverrides in responses#115
Open
nik-localstack wants to merge 1 commit intolocalstack:localstackfrom
Open
ec2: Enhance fleet creation with LaunchTemplateAndOverrides in responses#115nik-localstack wants to merge 1 commit intolocalstack:localstackfrom
nik-localstack wants to merge 1 commit intolocalstack:localstackfrom
Conversation
nik-localstack
force-pushed
the
nikos/unc-263
branch
from
5cd4cd1 to
f995523
Compare
nik-localstack
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When creating an EC2 Fleet with
Type=instant, the response was missing theLaunchTemplateAndOverridesfield for each instance. This field is present in real AWS responses and contains important information about which launch template and overrides were used to launch each instance.Note: this field is necessary for Karpenter, otherwise it fails to parse the response.
Changes
array in thecreate_fleetresponse now includesLaunchTemplateAndOverrides` with:LaunchTemplateSpecification- Launch template ID and version usedOverrides- Any overrides applied (instance type, subnet, AZ, etc.)$Latestis now resolved to the actual version number (e.g., "1") in responses, matching AWS