ec2: Add dry run error handling for fleet creation#114
Open
nik-localstack wants to merge 1 commit intolocalstack:localstackfrom
Open
ec2: Add dry run error handling for fleet creation#114nik-localstack wants to merge 1 commit intolocalstack:localstackfrom
nik-localstack wants to merge 1 commit intolocalstack:localstackfrom
Conversation
nik-localstack
force-pushed
the
nikos/unc-265
branch
from
0d4b5b6 to
05a6ddc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Karpenter calls
create_fleetoperation withDryRun=trueCurrent moto implementation still tries to create these ec2 instances, which leads to unexpected behavior
Changes
Add proper response and return early when dry run is used in fleet creation