Repository navigation
Add CI that checks Snowflake and Trino share the Iceberg table - #3
Merged
Merged
Conversation
test.sh runs script.sql on LocalStack for Snowflake, reads the table back from Trino through Polaris and checks the Iceberg files in S3. The catalog setup script now fails on HTTP errors, and make run uses the compose service, since polaris:8181 only resolves inside the compose network. Claude-Session: https://claude.ai/code/session_01DZfDmzUBPqNAu3yFKyfCNM
docker-compose.yml required LOCALSTACK_AUTH_TOKEN, so make stop, make logs and docker compose exec failed unless the token was exported. make start still checks it. Claude-Session: https://claude.ai/code/session_01DZfDmzUBPqNAu3yFKyfCNM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo had no CI, and nothing checked that the demo works.
test.sh(make test) walks through the demo on a freshly started stack:create-polaris-catalogcontainer exits 0, and the Polaris API returns thepolariscatalog with base locations3://test-bucket/testtest-bucket, then runsscript.sqlstatement by statement on LocalStack for Snowflake throughsnowflake-connector-python, and checks the finalSELECTreturnsfoobarandtesticeberg.test_namespace.iceberg_tables3://test-bucket/test/holds Parquet data files and Icebergmetadata.jsonfilescreate-polaris-catalog.shnow checks HTTP status codes. Before,curl -iwithout--failprinted "Catalog created successfully" even when Polaris rejected the request. A 409 (catalog exists) is accepted, so the script can run again.make runran the setup script on the host, wherehttp://polaris:8181does not resolve. It now runs the compose service.make checklooks for the AWS CLI instead of lstk, which the demo does not use.docker-compose.ymlrequiredLOCALSTACK_AUTH_TOKENfor every compose command, somake stop,make logsanddocker compose execfailed unless the token was exported. It now defaults to empty, andmake startstill checks that it is set.make startalready runs,docker composeinstead ofdocker-compose, and the LocalStack health URL.make start, runsmake test, prints container logs on failure.Verified by CI.
https://claude.ai/code/session_01DZfDmzUBPqNAu3yFKyfCNM