Skip to content

Removing leading NL, compatible with Python textwrap.dedent("""\.#14

Open
marhar wants to merge 5 commits into
lithammer:masterfrom
marhar:master
Open

Removing leading NL, compatible with Python textwrap.dedent("""\.#14
marhar wants to merge 5 commits into
lithammer:masterfrom
marhar:master

Conversation

@marhar

@marhar marhar commented May 23, 2022

Copy link
Copy Markdown

(sorry for the previous polluted pull request, my git-fu seems to be weak!)

@silverwind

silverwind commented May 24, 2022

Copy link
Copy Markdown

Agree but I think it should also strip trailing newlines, e.g. perform a strings.TrimSpace, which would match the behaviour of https://github.com/dmnd/dedent.

@lithammer

lithammer commented May 27, 2022

Copy link
Copy Markdown
Owner

It seems like this is basically a duplicate of #7 (but less efficient).

@lithammer

Copy link
Copy Markdown
Owner

Not sure why you're messing around with go.mod either?

@marhar

marhar commented May 27, 2022

Copy link
Copy Markdown
Author

Try it now... I think my mental model is broken, I was thinking it was a self-contained patch, and was fiddling around to understand go.mod. I think I've set everything back to how it should be and won't touch it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants