Skip to content

fix(kart): more robust feature counts BM-1734#199

Merged
schmidtnz merged 4 commits into
masterfrom
fix/kart-diff-fails-when-many-features-change-BM-1734
Jun 17, 2026
Merged

fix(kart): more robust feature counts BM-1734#199
schmidtnz merged 4 commits into
masterfrom
fix/kart-diff-fails-when-many-features-change-BM-1734

Conversation

@schmidtnz

@schmidtnz schmidtnz commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Motivation

kart diff action fails for large changes.
When the changeset produces > 512MB of text, node crashes.

Modifications

  • Use kart internal count of changed features.
  • Use files for diff output
  • Only process diffs up to a max number of changed features (currently 1000).

Verification

added tests and manual end to end testing

@schmidtnz schmidtnz marked this pull request as ready for review June 16, 2026 21:39
@schmidtnz schmidtnz requested a review from a team as a code owner June 16, 2026 21:39
@schmidtnz schmidtnz force-pushed the fix/kart-diff-fails-when-many-features-change-BM-1734 branch from 01088ee to eeb94ac Compare June 16, 2026 22:43
@schmidtnz schmidtnz added this pull request to the merge queue Jun 17, 2026
Merged via the queue into master with commit 4be686d Jun 17, 2026
8 of 10 checks passed
@schmidtnz schmidtnz deleted the fix/kart-diff-fails-when-many-features-change-BM-1734 branch June 17, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants