Repository navigation
fix: stop enabling the package dependency widget by default - #5175
Conversation
Refs linuxfoundation/lfx-cdp-insights-ops#976 Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
PR SummaryLow Risk Overview
A Flyway migration strips Reviewed by Cursor Bugbot for commit 5bbb961. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change to disable the Package dependency widget by default.
No open issues 🎉
What changed in this PR
Stops the Package dependency widget from being enabled by default in Insights projects, following the Package downloads change in #5173.
Changes:
- Disables the shared default so integration changes no longer automatically add the widget.
- Removes
packageDependencyfrom existing projects and updates their modification timestamps, while preserving manual opt-in.
| File | Description |
|---|---|
services/libs/types/src/enums/widgets.ts |
Sets the Package dependency widget default to disabled. |
backend/src/database/migrations/V1793704577__removePackageDependencyWidget.sql |
Removes the widget from affected projects and refreshes updatedAt. |
Review effort: Balanced
[Medium impact] The PR appears safe to merge. SummaryTurns off the Package dependency widget by default and removes it from existing projects.
Reviews (1) · Last reviewed commit: "fix: stop enabling the package dependenc..." · Reviewed by Greptile |
Summary
Turns off the Package dependency widget for all Insights projects, as #5173 did for Package downloads.
DEFAULT_WIDGET_VALUESstill enables it for GitHub and GitHub Nango, so every integration change adds it back. 8,436 projects in prod have it.Changes
PACKAGE_DEPENDENCYtoenabled: falseinDEFAULT_WIDGET_VALUES. Integration changes no longer add it, and the admin "add project" form no longer ticks it when it loads a segment's widgets. Admins can still turn it on by hand.packageDependencyfrom everyinsightsProjectsrow that has it.Type of change
Related issue
Refs linuxfoundation/lfx-cdp-insights-ops#976