Skip to content

fix: stop enabling the package dependency widget by default - #5175

Merged
joanagmaia merged 1 commit into
mainfrom
fix/issue-976-disable-package-dependency-widget
Nov 3, 2026
Merged

joanagmaia merged 1 commit into
mainfrom
fix/issue-976-disable-package-dependency-widget

Conversation

@joanagmaia

Copy link
Copy Markdown
Contributor

Summary

Turns off the Package dependency widget for all Insights projects, as #5173 did for Package downloads. DEFAULT_WIDGET_VALUES still enables it for GitHub and GitHub Nango, so every integration change adds it back. 8,436 projects in prod have it.

Changes

  • Set PACKAGE_DEPENDENCY to enabled: false in DEFAULT_WIDGET_VALUES. Integration changes no longer add it, and the admin "add project" form no longer ticks it when it loads a segment's widgets. Admins can still turn it on by hand.
  • Add a migration that removes packageDependency from every insightsProjects row that has it.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Performance improvement
  • Chore / dependency update
  • Documentation

Related issue

Refs linuxfoundation/lfx-cdp-insights-ops#976

Refs linuxfoundation/lfx-cdp-insights-ops#976

Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
Copilot AI balanced review requested due to automatic review settings November 3, 2026 11:17
@cursor

cursor Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
One-time SQL update to project widget arrays; no auth or ingestion logic changes, and the widget remains opt-in via admin settings.

Overview
Disables the Package dependency Insights widget by default, mirroring the earlier Package downloads change.

DEFAULT_WIDGET_VALUES now sets PACKAGE_DEPENDENCY to enabled: false, so new or updated integrations and the admin project form no longer auto-include it. Admins can still enable it manually.

A Flyway migration strips 'packageDependency' from the widgets array on every insightsProjects row that still has it, cleaning up existing projects in production.

Reviewed by Cursor Bugbot for commit 5bbb961. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the change to disable the Package dependency widget by default.

No open issues 🎉

What changed in this PR

Stops the Package dependency widget from being enabled by default in Insights projects, following the Package downloads change in #5173.

Changes:

  • Disables the shared default so integration changes no longer automatically add the widget.
  • Removes packageDependency from existing projects and updates their modification timestamps, while preserving manual opt-in.
File Description
services/​libs/​types/​src/​enums/​widgets.ts Sets the Package dependency widget default to disabled.
backend/​src/​database/​migrations/​V1793704577__removePackageDependencyWidget.sql Removes the widget from affected projects and refreshes updatedAt.

Review effort: Balanced

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Turns off the Package dependency widget by default and removes it from existing projects.

  • Segment widget suggestions leave package dependency out by default.
  • Existing project settings no longer keep the package dependency widget.

Reviews (1) · Last reviewed commit: "fix: stop enabling the package dependenc..." · Reviewed by Greptile

@joanagmaia
joanagmaia merged commit 9b69b7e into main Nov 3, 2026
15 checks passed
@joanagmaia
joanagmaia deleted the fix/issue-976-disable-package-dependency-widget branch November 3, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants