feat: add ComboBox blur preference#626
Closed
fly602 wants to merge 1 commit into
Closed
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1. Added new `hasInWindowBlur` property to `DQMLGlobalObject` for QML access 2. Updated InWindowBlur component to use `hasInWindowBlur` for blur disabling 3. Updated debian/control with minimum version requirements for dtk dependencies 4. Changed copyright year to 2023-2026 Log: Added hasInWindowBlur QML property for blur availability check Influence: 1. Test hasInWindowBlur property returns correct boolean on various platforms 2. Verify InWindowBlur component disables blur when hasInWindowBlur is false 3. Test build and installation with different dtk versions 4. Verify version dependency requirements in debian/control 5. Test blur rendering behavior with software renderer 6. Verify signal emission when hasInWindowBlur changes feat: 添加 hasInWindowBlur QML 属性和版本依赖 1. 为 DQMLGlobalObject 添加了新的 hasInWindowBlur 属性供 QML 访问 2. 更新 InWindowBlur 组件使用 hasInWindowBlur 来控制模糊效果开关 3. 更新 debian/control 文件增加 dtk 依赖的最低版本要求 4. 将版权年份更新为 2023-2026 Log: 新增 hasInWindowBlur QML 属性用于检测模糊可用性 Influence: 1. 测试 hasInWindowBlur 属性在不同平台上返回正确布尔值 2. 验证当 hasInWindowBlur 为 false 时 InWindowBlur 组件正确关闭模糊效果 3. 测试不同 dtk 版本下的构建和安装 4. 验证 debian/control 中的版本依赖要求 5. 测试配合软件渲染器时模糊效果的行为 6. 验证 hasInWindowBlur 变化时信号正确发射 PMS: TASK-390117
Contributor
deepin pr auto review你好!我是CodeGeeX。我已仔细审查了你提供的 Git Diff。本次修改主要涉及三个方面:Debian 打包依赖版本约束更新、版权声明年份更新、以及为 DTK 新增 以下是针对语法逻辑、代码质量、代码性能和代码安全四个维度的详细审查意见和改进建议: 1. 语法与逻辑
2. 代码质量
3. 代码性能
4. 代码安全
综合修改建议代码片段1. C++ 头文件 ( // 假设该属性运行时不变,建议移除 NOTIFY 并改为 CONSTANT,移除函数的 static
Q_PROPERTY(bool hasInWindowBlur READ hasInWindowBlur CONSTANT)
// ...
bool hasInWindowBlur() const; // 移除 static
// ...
// 移除 void hasInWindowBlurChanged(); 信号声明2. C++ 源文件 ( bool DQMLGlobalObject::hasInWindowBlur() const // 移除 static
{
// 引入 static 缓存,提升性能
static bool hasBlur = DGuiApplicationHelper::testAttribute(DGuiApplicationHelper::HasInWindowBlur);
return hasBlur;
}3. Debian 控制文件 ( - libdtk6gui-dev (>> 6.7.42),
- libdtkcommon-dev (>> 6.7.42),
+ libdtk6gui-dev (>= 6.7.42),
+ libdtkcommon-dev (>= 6.7.42),4. QML 文件 ( - // SPDX-FileCopyrightText: 2023 - 2026 UnionTech Software Technology Co., Ltd.
+ // SPDX-FileCopyrightText: 2023 - 2024 UnionTech Software Technology Co., Ltd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Added a configurable blur effect option for ComboBox dropdowns
Influence:
feat: 新增 ComboBox 模糊效果配置
Log: 为 ComboBox 下拉框新增可配置的模糊效果选项
Influence:
PMS: BUG-358837
Change-Id: Ifd7255009fa87539481ebb515f93f89ac5958ce5