Skip to content

feat(inputdevices): disable touchpad gestures when mouse is plugged in#1122

Open
52cyb wants to merge 1 commit into
linuxdeepin:masterfrom
52cyb:master
Open

feat(inputdevices): disable touchpad gestures when mouse is plugged in#1122
52cyb wants to merge 1 commit into
linuxdeepin:masterfrom
52cyb:master

Conversation

@52cyb
Copy link
Copy Markdown
Contributor

@52cyb 52cyb commented May 23, 2026

Sync touchpad gesture state with touchpad hardware state in setDisableTemporary, so gestures are disabled together with the touchpad when a mouse is inserted and re-enabled when the mouse is removed.

插入鼠标禁用触控板时,同步禁用触控板手势;拔出鼠标时恢复手势。

Log: 插入鼠标禁用触控板时同步禁用手势
PMS: 360815
Influence: 开启"插入鼠标时禁用触控板"后,插入鼠标会同时禁用触控板手势,拔出后自动恢复。

Summary by Sourcery

New Features:

  • Disable touchpad gestures together with the touchpad when a mouse is plugged in, and re-enable gestures when the mouse is removed.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 52cyb

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Copy Markdown

Hi @52cyb. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 23, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Synchronizes temporary touchpad disablement with gesture state so that gestures are turned off and back on alongside the touchpad when a mouse is plugged in or removed.

Sequence diagram for syncing touchpad and gesture disablement

sequenceDiagram
    participant InputDeviceManager
    participant Touchpad
    participant GestureSystem

    InputDeviceManager->>Touchpad: setDisableTemporary(true)
    Touchpad->>GestureSystem: enableGesture(false)

    InputDeviceManager->>Touchpad: setDisableTemporary(false)
    Touchpad->>GestureSystem: enableGesture(true)
Loading

File-Level Changes

Change Details Files
Synchronize touchpad temporary disable state with gesture enablement when a mouse is plugged in or removed.
  • Extend the temporary disable helper comment to clarify it affects both the touchpad and gestures.
  • After iterating over device infos to set their disabled state, invoke gesture enabling/disabling via enableGesture(!disable) so gestures track the hardware state.
inputdevices1/touchpad.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since setDisableTemporary now also toggles gesture state, consider updating its name or adding a brief comment about the side effect on global gesture state to make its broader responsibility clearer to future readers.
  • If enableGesture has side effects beyond the current touchpad instance or can be expensive, you may want to guard the call to avoid redundant toggles (e.g., only call when the gesture state actually needs to change) or ensure it’s safe in the context where setDisableTemporary is invoked.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since `setDisableTemporary` now also toggles gesture state, consider updating its name or adding a brief comment about the side effect on global gesture state to make its broader responsibility clearer to future readers.
- If `enableGesture` has side effects beyond the current touchpad instance or can be expensive, you may want to guard the call to avoid redundant toggles (e.g., only call when the gesture state actually needs to change) or ensure it’s safe in the context where `setDisableTemporary` is invoked.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented May 25, 2026

TAG Bot

New tag: 6.1.92
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1127

Sync touchpad gesture state with touchpad hardware state in setDisableTemporary, so gestures are disabled together with the touchpad when a mouse is inserted and re-enabled when the mouse is removed.

插入鼠标禁用触控板时,同步禁用触控板手势;拔出鼠标时恢复手势。

Log: 插入鼠标禁用触控板时同步禁用手势
PMS: 360815
Influence: 开启"插入鼠标时禁用触控板"后,插入鼠标会同时禁用触控板手势,拔出后自动恢复。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants