Complete OPT_ARGS to NVME_ARGS conversion across plugin subsystem#3095
Closed
Complete OPT_ARGS to NVME_ARGS conversion across plugin subsystem#3095
Conversation
Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace remaining instances of OPT_ARGS with NVME_ARGS
Complete OPT_ARGS to NVME_ARGS conversion across plugin subsystem
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous patch converted nvme.c but left 193 OPT_ARGS instances in plugin files.
Changes
Converted OPT_ARGS to NVME_ARGS in 42 files:
fabrics.c,nvme-rpmb.cBefore:
After:
NVME_ARGS automatically includes:
verbose,output-format,timeout,dry-run,no-retries,output-format-version.Not Converted
plugins/sed/sed.c(6 instances) - global option arrays use customsedopal_discovery_verboseflag instead ofnvme_cfg.verbose, creating conflict with NVME_ARGS's built-in verbose option.Impact
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
git.sr.ht/usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.