Skip to content

Complete OPT_ARGS to NVME_ARGS conversion across plugin subsystem#3095

Closed
Copilot wants to merge 6 commits intomasterfrom
copilot/replace-opt-args-with-nvme-args
Closed

Complete OPT_ARGS to NVME_ARGS conversion across plugin subsystem#3095
Copilot wants to merge 6 commits intomasterfrom
copilot/replace-opt-args-with-nvme-args

Conversation

Copy link

Copilot AI commented Feb 12, 2026

Previous patch converted nvme.c but left 193 OPT_ARGS instances in plugin files.

Changes

Converted OPT_ARGS to NVME_ARGS in 42 files:

  • Core: fabrics.c, nvme-rpmb.c
  • Plugins: all 40 plugin files with OPT_ARGS usage

Before:

OPT_ARGS(opts) = {
    OPT_FMT("output-format", 'o', &cfg.output_format, output_format),
    OPT_UINT("namespace-id", 'n', &cfg.nsid, namespace_id),
    OPT_END()
};

After:

NVME_ARGS(opts,
    OPT_UINT("namespace-id", 'n', &cfg.nsid, namespace_id));

NVME_ARGS automatically includes: verbose, output-format, timeout, dry-run, no-retries, output-format-version.

Not Converted

plugins/sed/sed.c (6 instances) - global option arrays use custom sedopal_discovery_verbose flag instead of nvme_cfg.verbose, creating conflict with NVME_ARGS's built-in verbose option.

Impact

  • Removes ~440 lines of duplicate option definitions
  • Standardizes common option behavior across all commands

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • git.sr.ht
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 5 commits February 12, 2026 16:45
Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace remaining instances of OPT_ARGS with NVME_ARGS Complete OPT_ARGS to NVME_ARGS conversion across plugin subsystem Feb 12, 2026
Copilot AI requested a review from igaw February 12, 2026 16:54
@igaw igaw closed this Feb 12, 2026
@igaw igaw deleted the copilot/replace-opt-args-with-nvme-args branch February 12, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants