plugins/solidigm: parse telemetry error message improvements.#3092
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Feb 12, 2026
Merged
plugins/solidigm: parse telemetry error message improvements.#3092igaw merged 1 commit intolinux-nvme:masterfrom
igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
Improved parameter checking. Improved error message and return codes. Better JSON parser error message Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
igaw
reviewed
Feb 12, 2026
| errno = EINVAL; | ||
| nvme_show_perror("data-area = '%d'", cfg.data_area); | ||
| return -errno; | ||
| } |
Collaborator
There was a problem hiding this comment.
why not do return -EINVAL directly?
Collaborator
There was a problem hiding this comment.
scratch that. I think it's time to get nvme_show_perror eliminated.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved parameter checking.
Improved error message and return codes.
Better JSON parser error message